Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42932

Introduce calendar type choice at system level

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.7
    • Component/s: Calendar
    • Testing Instructions:
      Hide
      1. Install the calendar type 'test' (https://github.com/markn86/moodle-calendartype_test) into the folder calendar/type/test.
      2. Visit admin/index.php and install the 'test' calendar.
      3. Visit <yoursite>/admin/settings.php?section=calendar and set the calendar type default to 'test' (it should be 'gregorian' by default').
      4. Enable self registration.
      5. Create a user using the registration steps and ensure that the calendar type set for their profile is 'test'.
      6. Create a user using the web service functionality and ensure the calendar type in their profile is 'test'.
      7. Log in using the DB authentication plugin and ensure the user is created with the 'test' calendar type.
      8. Create a webservice script (see https://github.com/moodlehq/moodle-local_wstemplate/tree/master/client) to create a user with the 'gregorian' calendar type and check that they were created successfully with that calendar type.
      9. Create a webservice script to create a user without specifying the calendar type and check that the calendar type was set to 'test'.
      10. Create a webservice script to create a user specifying the calendar type as '' and check that the calendar type was set to 'test'.
      11. Create a webservice script to update a user's calendar type (who was originally set to 'gregorian') to 'test' and check that it was updated.
      12. Create a webservice script to update a user (but not their calendar type) and ensure there calendar type was not altered.
      13. Create a webservice script to update a user's calendar type (who was originally set to 'gregorian') to '' and check that it was not updated.
      Show
      Install the calendar type 'test' ( https://github.com/markn86/moodle-calendartype_test ) into the folder calendar/type/test. Visit admin/index.php and install the 'test' calendar. Visit <yoursite>/admin/settings.php?section=calendar and set the calendar type default to 'test' (it should be 'gregorian' by default'). Enable self registration. Create a user using the registration steps and ensure that the calendar type set for their profile is 'test'. Create a user using the web service functionality and ensure the calendar type in their profile is 'test'. Log in using the DB authentication plugin and ensure the user is created with the 'test' calendar type. Create a webservice script (see https://github.com/moodlehq/moodle-local_wstemplate/tree/master/client ) to create a user with the 'gregorian' calendar type and check that they were created successfully with that calendar type. Create a webservice script to create a user without specifying the calendar type and check that the calendar type was set to 'test'. Create a webservice script to create a user specifying the calendar type as '' and check that the calendar type was set to 'test'. Create a webservice script to update a user's calendar type (who was originally set to 'gregorian') to 'test' and check that it was updated. Create a webservice script to update a user (but not their calendar type) and ensure there calendar type was not altered. Create a webservice script to update a user's calendar type (who was originally set to 'gregorian') to '' and check that it was not updated.
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull Master Branch:
      MDL-42932_master
    • Sprint:
      BACKEND Sprint 7
    • Sprint:
      BACKEND Sprint 7

      Description

      Currently you are only able to change the calendar type in the user and course settings.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            skodak Petr Skoda added a comment -

            1/ overridden has two DD, right?

            2/ I would expect hidden field with default in else following if (count($calendartypes) > 1) {

            3/ could we have some tests for this in externallib pleae?

            4/ why not add the missing fields centrally in user_create_user()?

            Ciao and thanks, I agree this is necessary.

            Show
            skodak Petr Skoda added a comment - 1/ overridden has two DD, right? 2/ I would expect hidden field with default in else following if (count($calendartypes) > 1) { 3/ could we have some tests for this in externallib pleae? 4/ why not add the missing fields centrally in user_create_user()? Ciao and thanks, I agree this is necessary.
            Hide
            markn Mark Nelson added a comment -

            Thanks Petr,

            1. Cheers! You are indeed correct.
            2. Is this necessary? There is already a DB default, so not specifying a calendar type is not really an issue when inserting records in the DB. Also, the only time this condition will be false is if only the gregorian calendar is present (it can not be deleted via the GUI), so the DB default of 'gregorian' is fine.
            3. I have moved the logic to core functions in user/lib.php rather than in the web service, so I am not sure it is necessary to create tests for externallib.php for this one.
            4. I moved all the logic into this function. Please let me know if this is what you were talking abt.

            Cheers!

            Show
            markn Mark Nelson added a comment - Thanks Petr, Cheers! You are indeed correct. Is this necessary? There is already a DB default, so not specifying a calendar type is not really an issue when inserting records in the DB. Also, the only time this condition will be false is if only the gregorian calendar is present (it can not be deleted via the GUI), so the DB default of 'gregorian' is fine. I have moved the logic to core functions in user/lib.php rather than in the web service, so I am not sure it is necessary to create tests for externallib.php for this one. I moved all the logic into this function. Please let me know if this is what you were talking abt. Cheers!
            Hide
            skodak Petr Skoda added a comment -

            2. I guess we should not rely on DB defaults here, the site might configure different default calendar, I believe it is better to use hidden fields consistently.

            more comments:

            a/ // Calendar settings - trailing . missing

            b/ adding email restrictions is not OK, there was no real internal requirement for email presence or uniqueness before - this is going to break stuff big time!

            c/ if (!empty($user->auth)) { if not ok when creating users, it must be present

            d/ the user update allows you to delete user->auth value which is not allowed

            e/ hmm, these two methods for creation and update of users modify the $user parameter - that seems wrong, we should do clone there and it should be properly documented

            f/ seems that user_udpate_user may create duplicate usernames and emails

            g/ user_update_user should not allow modification the mnethostid

            Hmm maybe this all needs a new cleanup issue and this could be kept for calendar stuff only...

            Show
            skodak Petr Skoda added a comment - 2. I guess we should not rely on DB defaults here, the site might configure different default calendar, I believe it is better to use hidden fields consistently. more comments: a/ // Calendar settings - trailing . missing b/ adding email restrictions is not OK, there was no real internal requirement for email presence or uniqueness before - this is going to break stuff big time! c/ if (!empty($user->auth)) { if not ok when creating users, it must be present d/ the user update allows you to delete user->auth value which is not allowed e/ hmm, these two methods for creation and update of users modify the $user parameter - that seems wrong, we should do clone there and it should be properly documented f/ seems that user_udpate_user may create duplicate usernames and emails g/ user_update_user should not allow modification the mnethostid Hmm maybe this all needs a new cleanup issue and this could be kept for calendar stuff only...
            Hide
            markn Mark Nelson added a comment -

            Hi Petr, those comments are related to MDL-42935, can you comment there? I simply rebased this on top of that one as I knew there would be conflicts. Sorry.

            Show
            markn Mark Nelson added a comment - Hi Petr, those comments are related to MDL-42935 , can you comment there? I simply rebased this on top of that one as I knew there would be conflicts. Sorry.
            Hide
            skodak Petr Skoda added a comment - - edited

            oh, the calendar commit looks ok, the other one needs a bit more work imho

            Show
            skodak Petr Skoda added a comment - - edited oh, the calendar commit looks ok, the other one needs a bit more work imho
            Hide
            skodak Petr Skoda added a comment -

            great, +1 for integration

            Show
            skodak Petr Skoda added a comment - great, +1 for integration
            Hide
            markn Mark Nelson added a comment -

            Thanks Petr.

            To integrators, I personally think this should go in 2.6, but it is up to you whether or not this does.

            Show
            markn Mark Nelson added a comment - Thanks Petr. To integrators, I personally think this should go in 2.6, but it is up to you whether or not this does.
            Hide
            mohamadaliakbari Mohammad ali Akbari added a comment -

            How can i find a simple patch file to apply on my moodle?

            Show
            mohamadaliakbari Mohammad ali Akbari added a comment - How can i find a simple patch file to apply on my moodle?
            Hide
            poltawski Dan Poltawski added a comment -

            Hi Mark,

            I personally think you should've got the feature finished by 2.6 and then this would've been available.

            This is an improvement, not a bug and so will only go into master. Please file a backport request to request its backport to 2.6 and we'll vote on it: http://docs.moodle.org/dev/Integration_Review#Process_for_requesting_a_non_bug-fix_backport

            Show
            poltawski Dan Poltawski added a comment - Hi Mark, I personally think you should've got the feature finished by 2.6 and then this would've been available. This is an improvement, not a bug and so will only go into master. Please file a backport request to request its backport to 2.6 and we'll vote on it: http://docs.moodle.org/dev/Integration_Review#Process_for_requesting_a_non_bug-fix_backport
            Hide
            poltawski Dan Poltawski added a comment -

            Integrated to master only - thanks.

            Show
            poltawski Dan Poltawski added a comment - Integrated to master only - thanks.
            Hide
            markn Mark Nelson added a comment - - edited

            Yep, I unfortunately overlooked this setting, so have only just implemented it now. I have created MDL-43169 requesting this to be backported. Cheers.

            Show
            markn Mark Nelson added a comment - - edited Yep, I unfortunately overlooked this setting, so have only just implemented it now. I have created MDL-43169 requesting this to be backported. Cheers.
            Hide
            poltawski Dan Poltawski added a comment -

            Hi Mark,

            core_userliblib_testcase::test_create_users
            Undefined variable: CFG
             
            /Users/Shared/Jenkins/Home/git_repositories/master/user/lib.php:71
            /Users/Shared/Jenkins/Home/git_repositories/master/user/tests/userlib_test.php:107
            /Users/Shared/Jenkins/Home/git_repositories/master/lib/phpunit/classes/advanced_testcase.php:80
            

            auth_db_testcase::test_plugin
            Undefined variable: CFG
             
            /Users/Shared/Jenkins/Home/git_repositories/master/user/lib.php:71
            /Users/Shared/Jenkins/Home/git_repositories/master/lib/moodlelib.php:4039
            /Users/Shared/Jenkins/Home/git_repositories/master/auth/db/tests/db_test.php:300
            /Users/Shared/Jenkins/Home/git_repositories/master/lib/phpunit/classes/advanced_testcase.php:80
            

            Show
            poltawski Dan Poltawski added a comment - Hi Mark, core_userliblib_testcase::test_create_users Undefined variable: CFG   /Users/Shared/Jenkins/Home/git_repositories/master/user/lib.php:71 /Users/Shared/Jenkins/Home/git_repositories/master/user/tests/userlib_test.php:107 /Users/Shared/Jenkins/Home/git_repositories/master/lib/phpunit/classes/advanced_testcase.php:80 auth_db_testcase::test_plugin Undefined variable: CFG   /Users/Shared/Jenkins/Home/git_repositories/master/user/lib.php:71 /Users/Shared/Jenkins/Home/git_repositories/master/lib/moodlelib.php:4039 /Users/Shared/Jenkins/Home/git_repositories/master/auth/db/tests/db_test.php:300 /Users/Shared/Jenkins/Home/git_repositories/master/lib/phpunit/classes/advanced_testcase.php:80
            Hide
            poltawski Dan Poltawski added a comment -

            This looks completely untested? You are not doing your backport request very much good..

            Show
            poltawski Dan Poltawski added a comment - This looks completely untested? You are not doing your backport request very much good..
            Hide
            markn Mark Nelson added a comment -

            I am not sure why I missed this. I tested using two scripts I created (which I also attached to MDL-42935). Originally the logic was here, but was moved out to two separate issues and maybe this broke something. Sorry.

            Show
            markn Mark Nelson added a comment - I am not sure why I missed this. I tested using two scripts I created (which I also attached to MDL-42935 ). Originally the logic was here, but was moved out to two separate issues and maybe this broke something. Sorry.
            Hide
            markn Mark Nelson added a comment - - edited
            Show
            markn Mark Nelson added a comment - - edited Hi Dan, please pull https://github.com/markn86/moodle/commit/4c61097cc7 Thanks.
            Hide
            poltawski Dan Poltawski added a comment -

            Thanks Mark

            Show
            poltawski Dan Poltawski added a comment - Thanks Mark
            Hide
            poltawski Dan Poltawski added a comment -

            Failing again:

            03. Moodle exception: Error writing to database More information about this error
             
                Debug info:
                 ERROR:  null value in column "calendartype" violates not-null constraint
                DETAIL:  Failing row contains (3, manual, 1, 0, 0, 0, 1, jonest, $2y$04$j1kwOixwTZhed.Gi1JtV7.0MKBkAxDEayuQ3Njyy3XwtpPVDuXwa2, , Tom, Jones, jonest@someplace.edu, 0, , , , , , , , , , , Perth, AU, en, null, , 99, 0, 0, 0, 0, , , 0, , , 1, 1, 0, 2, 1, 0, 1386049828, 1386049828, 0, null, null, null, null, null).
                INSERT INTO euser (username,password,firstname,lastname,email,mnethostid,city,country,lang,timezone,mailformat,maildisplay,maildigest,autosubscribe,institution,department,idnumber,phone1,phone2,address,url,description,descriptionformat,auth,confirmed,timemodified,timecreated,suspended,calendartype) VALUES($1,$2,$3,$4,$5,$6,$7,$8,$9,$10,$11,$12,$13,$14,$15,$16,$17,$18,$19,$20,$21,$22,$23,$24,$25,$26,$27,$28,$29) RETURNING id
                [array (
                  'username' => 'jonest',
                  'password' => '$2y$04$j1kwOixwTZhed.Gi1JtV7.0MKBkAxDEayuQ3Njyy3XwtpPVDuXwa2',
                  'firstname' => 'Tom',
                  'lastname' => 'Jones',
                  'email' => 'jonest@someplace.edu',
                  'mnethostid' => '1',
                  'city' => 'Perth',
                  'country' => 'AU',
                  'lang' => 'en',
                  'timezone' => '99',
                  'mailformat' => '1',
                  'maildisplay' => '2',
                  'maildigest' => '0',
                  'autosubscribe' => '1',
                  'institution' => '',
                  'department' => '',
                  'idnumber' => '',
                  'phone1' => '',
                  'phone2' => '',
                  'address' => '',
                  'url' => '',
                  'description' => '',
                  'descriptionformat' => '1',
                  'auth' => 'manual',
                  'confirmed' => 1,
                  'timemodified' => 1386049828,
                  'timecreated' => 1386049828,
                  'suspended' => 0,
                  'calendartype' => NULL,
                )]
                Error code: dmlwriteexception
             
                Stack trace:
             
                line 444 of /lib/dml/moodle_database.php: dml_write_exception thrown
                line 239 of /lib/dml/pgsql_native_moodle_database.php: call to moodle_database->query_end()
                line 848 of /lib/dml/pgsql_native_moodle_database.php: call to pgsql_native_moodle_database->query_end()
                line 900 of /lib/dml/pgsql_native_moodle_database.php: call to pgsql_native_moodle_database->insert_record_raw()
                line 78 of /user/lib.php: call to pgsql_native_moodle_database->insert_record()
                line 805 of /admin/tool/uploaduser/index.php: call to user_create_user()
                In step `And I press "Upload users"'.                              # behat_forms::press_button()
                From scenario `Upload users enrolling them on courses and groups'. # /Users/danp/moodles/im_behating/moodle/admin/tests/behat/upload_users.feature:8
                Of feature `Upload users'.                                         # /Users/danp/moodles/im_behating/moodle/admin/tests/behat/upload_users.feature
            

            Show
            poltawski Dan Poltawski added a comment - Failing again: 03. Moodle exception: Error writing to database More information about this error   Debug info: ERROR: null value in column "calendartype" violates not-null constraint DETAIL: Failing row contains (3, manual, 1, 0, 0, 0, 1, jonest, $2y$04$j1kwOixwTZhed.Gi1JtV7.0MKBkAxDEayuQ3Njyy3XwtpPVDuXwa2, , Tom, Jones, jonest@someplace.edu, 0, , , , , , , , , , , Perth, AU, en, null, , 99, 0, 0, 0, 0, , , 0, , , 1, 1, 0, 2, 1, 0, 1386049828, 1386049828, 0, null, null, null, null, null). INSERT INTO euser (username,password,firstname,lastname,email,mnethostid,city,country,lang,timezone,mailformat,maildisplay,maildigest,autosubscribe,institution,department,idnumber,phone1,phone2,address,url,description,descriptionformat,auth,confirmed,timemodified,timecreated,suspended,calendartype) VALUES($1,$2,$3,$4,$5,$6,$7,$8,$9,$10,$11,$12,$13,$14,$15,$16,$17,$18,$19,$20,$21,$22,$23,$24,$25,$26,$27,$28,$29) RETURNING id [array ( 'username' => 'jonest', 'password' => '$2y$04$j1kwOixwTZhed.Gi1JtV7.0MKBkAxDEayuQ3Njyy3XwtpPVDuXwa2', 'firstname' => 'Tom', 'lastname' => 'Jones', 'email' => 'jonest@someplace.edu', 'mnethostid' => '1', 'city' => 'Perth', 'country' => 'AU', 'lang' => 'en', 'timezone' => '99', 'mailformat' => '1', 'maildisplay' => '2', 'maildigest' => '0', 'autosubscribe' => '1', 'institution' => '', 'department' => '', 'idnumber' => '', 'phone1' => '', 'phone2' => '', 'address' => '', 'url' => '', 'description' => '', 'descriptionformat' => '1', 'auth' => 'manual', 'confirmed' => 1, 'timemodified' => 1386049828, 'timecreated' => 1386049828, 'suspended' => 0, 'calendartype' => NULL, )] Error code: dmlwriteexception   Stack trace:   line 444 of /lib/dml/moodle_database.php: dml_write_exception thrown line 239 of /lib/dml/pgsql_native_moodle_database.php: call to moodle_database->query_end() line 848 of /lib/dml/pgsql_native_moodle_database.php: call to pgsql_native_moodle_database->query_end() line 900 of /lib/dml/pgsql_native_moodle_database.php: call to pgsql_native_moodle_database->insert_record_raw() line 78 of /user/lib.php: call to pgsql_native_moodle_database->insert_record() line 805 of /admin/tool/uploaduser/index.php: call to user_create_user() In step `And I press "Upload users"'. # behat_forms::press_button() From scenario `Upload users enrolling them on courses and groups'. # /Users/danp/moodles/im_behating/moodle/admin/tests/behat/upload_users.feature:8 Of feature `Upload users'. # /Users/danp/moodles/im_behating/moodle/admin/tests/behat/upload_users.feature
            Hide
            poltawski Dan Poltawski added a comment -

            Hi Mark,

            This is breaking the complete behat suite combined with the other failure, so i'm reverting this issue.

            Please resubmit once you've fixed it and tested it more throughly.

            Show
            poltawski Dan Poltawski added a comment - Hi Mark, This is breaking the complete behat suite combined with the other failure, so i'm reverting this issue. Please resubmit once you've fixed it and tested it more throughly.
            Hide
            cibot CiBoT added a comment -

            Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

            Show
            cibot CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
            Hide
            markn Mark Nelson added a comment -

            I couldn't replicate this breakage on behat .. I suspect $CFG->calendartype had not been defined, and the only way this could be (that I can think of) is if the site had not been upgraded.

            Show
            markn Mark Nelson added a comment - I couldn't replicate this breakage on behat .. I suspect $CFG->calendartype had not been defined, and the only way this could be (that I can think of) is if the site had not been upgraded.
            Hide
            poltawski Dan Poltawski added a comment -

            Trying again by incrementing version

            Show
            poltawski Dan Poltawski added a comment - Trying again by incrementing version
            Hide
            poltawski Dan Poltawski added a comment -

            So far so good, (only part way through). So looks like you are probably right, sorry Mark.

            Show
            poltawski Dan Poltawski added a comment - So far so good, (only part way through). So looks like you are probably right, sorry Mark.
            Hide
            markn Mark Nelson added a comment -

            No problem. Let me know how it goes and I will send this back to integration if all goes well.

            Show
            markn Mark Nelson added a comment - No problem. Let me know how it goes and I will send this back to integration if all goes well.
            Hide
            mudrd8mz David Mudrak added a comment -

            Please instead of $string['calendartype'] and $string['configcalendartype'] can we start using the calendartype_desc variant? I know that consistency with the current code is important and we should convert all existing strings first. But maybe we can just stop introducing new config* strings first. See http://docs.moodle.org/dev/Help_strings for reference. Having these two strings with the same prefix will keep them together in alphabetical sorting which significantly helps translators to guess the context and the relationship of both strings.

            Show
            mudrd8mz David Mudrak added a comment - Please instead of $string ['calendartype'] and $string ['configcalendartype'] can we start using the calendartype_desc variant? I know that consistency with the current code is important and we should convert all existing strings first. But maybe we can just stop introducing new config* strings first. See http://docs.moodle.org/dev/Help_strings for reference. Having these two strings with the same prefix will keep them together in alphabetical sorting which significantly helps translators to guess the context and the relationship of both strings.
            Hide
            markn Mark Nelson added a comment -

            Hey David, I agree. It would be ideal if the strings were together in the language file. However, I just copied what the existing standard was, as I did not realise we had a doc regarding help string changes so assumed the standard used in the file was ideal. I have amended the commit to use 'calendartype_desc', rather than 'configcalendartype'.

            Show
            markn Mark Nelson added a comment - Hey David, I agree. It would be ideal if the strings were together in the language file. However, I just copied what the existing standard was, as I did not realise we had a doc regarding help string changes so assumed the standard used in the file was ideal. I have amended the commit to use 'calendartype_desc', rather than 'configcalendartype'.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Mark - this has been integrated now

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Mark - this has been integrated now
            Hide
            damyon Damyon Wiese added a comment -

            All testing instructions passed and I tested around a few more things and the validation seems pretty solid.

            Only tested on master. Passing!

            Show
            damyon Damyon Wiese added a comment - All testing instructions passed and I tested around a few more things and the validation seems pretty solid. Only tested on master. Passing!
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks for the code, its now upstream!

            Heres a fun trick to try in the spirit of Friday the 13th.
            I hear if you stand in front a mirror, alone, in the dark, and say "Oracle" three times Petr Skoka will appear in the mirror and you'll see him deleting the Oracle driver from Moodle.

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks for the code, its now upstream! Heres a fun trick to try in the spirit of Friday the 13th. I hear if you stand in front a mirror, alone, in the dark, and say "Oracle" three times Petr Skoka will appear in the mirror and you'll see him deleting the Oracle driver from Moodle.
            Hide
            mudrd8mz David Mudrak added a comment -

            Thanks Mark for amending the string names. See the attached screenshot that hopefully illustrates it clearly that the new naming policy is just better. Cheers.

            Show
            mudrd8mz David Mudrak added a comment - Thanks Mark for amending the string names. See the attached screenshot that hopefully illustrates it clearly that the new naming policy is just better. Cheers.
            Hide
            rezaie9 Shamim Rezaie added a comment -

            Is this included in 2.6.1 (Build: 20140113)?
            I just installed 2.6.1 and the <yoursite>/admin/settings.php?section=calendar page does not have a setting to set the default calendar.

            Show
            rezaie9 Shamim Rezaie added a comment - Is this included in 2.6.1 (Build: 20140113)? I just installed 2.6.1 and the <yoursite>/admin/settings.php?section=calendar page does not have a setting to set the default calendar.
            Hide
            skodak Petr Skoda added a comment -

            Hello, this new feature will be available in 2.7 only - see the "Fix version:" field at the top of this page.

            Show
            skodak Petr Skoda added a comment - Hello, this new feature will be available in 2.7 only - see the "Fix version:" field at the top of this page.
            Hide
            marycooch Mary Cooch added a comment -

            Currently it is only in 2.7, Shamin.

            Show
            marycooch Mary Cooch added a comment - Currently it is only in 2.7, Shamin.
            Hide
            rezaie9 Shamim Rezaie added a comment -

            Petr, Mary,
            Just noticed the fix version is 2.7
            Thanks for your reply

            Show
            rezaie9 Shamim Rezaie added a comment - Petr, Mary, Just noticed the fix version is 2.7 Thanks for your reply
            Hide
            marycooch Mary Cooch added a comment -

            Just asking for clarification here as I document this - I see that the default calendar type is also available in 2.6.2 (ie on the sandbox site) so does that mean it was backported as well as being available in 2.7?

            Show
            marycooch Mary Cooch added a comment - Just asking for clarification here as I document this - I see that the default calendar type is also available in 2.6.2 (ie on the sandbox site) so does that mean it was backported as well as being available in 2.7?
            Hide
            marycooch Mary Cooch added a comment -

            It's ok - I saw the other issue for 2.6.2 Removing docs_required as this is documented here http://docs.moodle.org/27/en/Calendar_settings - please check in case anything needs editing/improving.

            Show
            marycooch Mary Cooch added a comment - It's ok - I saw the other issue for 2.6.2 Removing docs_required as this is documented here http://docs.moodle.org/27/en/Calendar_settings - please check in case anything needs editing/improving.
            Hide
            rezaie9 Shamim Rezaie added a comment -

            Hi Mary
            you're right. It's added to 2.6.2

            Show
            rezaie9 Shamim Rezaie added a comment - Hi Mary you're right. It's added to 2.6.2

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/May/14

                  Agile