Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42989

AJAX admin menu JSON parse error

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.6.1
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      *Log in as admin

      • With debug_developer disabled
      • Expand admin menu
        • Confirm that it was opened correctly
      • Enable debug_Developer
      • Refresh the page
      • Expand admin menu
        • Confirm that it was opened correctly
      • Edit theme/splash/settings.php and add a leading character or something else invalid
      • With debug_developer enabled
      • Expand admin menu
        • Confirm that an error message was displayed
      • Disable debug_developer
      • Refresh the page
      • Expand the admin menu
        • Confirm that it was opened correctly
      Show
      *Log in as admin With debug_developer disabled Expand admin menu Confirm that it was opened correctly Enable debug_Developer Refresh the page Expand admin menu Confirm that it was opened correctly Edit theme/splash/settings.php and add a leading character or something else invalid With debug_developer enabled Expand admin menu Confirm that an error message was displayed Disable debug_developer Refresh the page Expand the admin menu Confirm that it was opened correctly
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-42989-master
    • Pull Master Diff URL:

      Description

      There is a lack of error handling in /lib/ajax/getsiteadminbranch.php which causes the JSON parser to easily fail if (for example) whitespace is output before the JSON.

      -> Update to Moodle 2.6
      -> Try to load the admin menu on the home page

      It fails on our build, with a JSON parser error.
      It should expand the admin menu.

        Attachments

          Issue Links

          blocks

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-43152 Linting issue in shifted JavaScript

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-40958 ajax_failure in dragdrop.js does not handle server timeouts

          • Minor - Minor loss of function where workaround is possible
          • Open
          is a regression caused by

          Improvement - An enhancement to an existing Moodle feature. MDL-41811 Load admin menus using AJAX when not on admin pages

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-43013 Site administration menu don't expand when using Chrome and Firefox for site admin

          • Major - Major loss of function, incorrect output
          • Closed

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              skylarkelty Skylar Kelty
              Peer reviewer:
              Rajesh Taneja
              Integrator:
              Dan Poltawski
              Tester:
              Rossiani Wijaya
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Jan/14