Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42989

AJAX admin menu JSON parse error

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 2.6.1
    • 2.6
    • JavaScript
    • MOODLE_26_STABLE
    • MOODLE_26_STABLE
    • MDL-42989-master
    • Hide

      *Log in as admin

      • With debug_developer disabled
      • Expand admin menu
        • Confirm that it was opened correctly
      • Enable debug_Developer
      • Refresh the page
      • Expand admin menu
        • Confirm that it was opened correctly
      • Edit theme/splash/settings.php and add a leading character or something else invalid
      • With debug_developer enabled
      • Expand admin menu
        • Confirm that an error message was displayed
      • Disable debug_developer
      • Refresh the page
      • Expand the admin menu
        • Confirm that it was opened correctly
      Show
      *Log in as admin With debug_developer disabled Expand admin menu Confirm that it was opened correctly Enable debug_Developer Refresh the page Expand admin menu Confirm that it was opened correctly Edit theme/splash/settings.php and add a leading character or something else invalid With debug_developer enabled Expand admin menu Confirm that an error message was displayed Disable debug_developer Refresh the page Expand the admin menu Confirm that it was opened correctly

    Description

      There is a lack of error handling in /lib/ajax/getsiteadminbranch.php which causes the JSON parser to easily fail if (for example) whitespace is output before the JSON.

      -> Update to Moodle 2.6
      -> Try to load the admin menu on the home page

      It fails on our build, with a JSON parser error.
      It should expand the admin menu.

      Attachments

        Issue Links

          Activity

            People

              dobedobedoh Andrew Lyons
              skylarkelty Skylar Kelty
              Rajesh Taneja Rajesh Taneja
              Dan Poltawski Dan Poltawski
              Rossiani Wijaya Rossiani Wijaya
              Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Clockify

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.