Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Major
Fix Version/s: 2.6.1
Affects Version/s: 2.6
Component/s: JavaScript
Labels:
- triaged

Affected Branches:
MOODLE_26_STABLE
Fixed Branches:
MOODLE_26_STABLE
Pull from Repository:
git://github.com/andrewnicols/moodle.git
Pull Main Branch:
~~MDL-42989~~-master
Pull Main Diff URL:
https://github.com/andrewnicols/moodle/compare/9b37cd7...MDL-42989-master
Testing Instructions:
Hide

*Log in as admin

With debug_developer disabled

Expand admin menu

Confirm that it was opened correctly

Enable debug_Developer

Refresh the page

Expand admin menu

Confirm that it was opened correctly

Edit theme/splash/settings.php and add a leading character or something else invalid

With debug_developer enabled

Expand admin menu

Confirm that an error message was displayed

Disable debug_developer

Refresh the page

Expand the admin menu

Confirm that it was opened correctly
Show
*Log in as admin With debug_developer disabled Expand admin menu Confirm that it was opened correctly Enable debug_Developer Refresh the page Expand admin menu Confirm that it was opened correctly Edit theme/splash/settings.php and add a leading character or something else invalid With debug_developer enabled Expand admin menu Confirm that an error message was displayed Disable debug_developer Refresh the page Expand the admin menu Confirm that it was opened correctly

There is a lack of error handling in /lib/ajax/getsiteadminbranch.php which causes the JSON parser to easily fail if (for example) whitespace is output before the JSON.

-> Update to Moodle 2.6
-> Try to load the admin menu on the home page

It fails on our build, with a JSON parser error.
It should expand the admin menu.

blocks

MDL-43152 Linting issue in shifted JavaScript

Closed

has a non-specific relationship to

MDL-40958 ajax_failure in dragdrop.js does not handle server timeouts

Closed

is a regression caused by

MDL-41811 Load admin menus using AJAX when not on admin pages

Closed

is duplicated by

MDL-43013 Site administration menu don't expand when using Chrome and Firefox for site admin

Closed

Assignee:: Andrew Lyons

Reporter:: Skylar Kelty

Peer reviewer:: Rajesh Taneja

Integrator:: Dan Poltawski

Tester:: Rossiani Wijaya

Participants:: Andrew Lyons, Damyon Wiese, Dan Poltawski, Joseph Rézeau, Rajesh Taneja, Renaat Debleu, Rossiani Wijaya, Skylar Kelty

Votes:: 0 Vote for this issue

Watchers:: 11 Start watching this issue

Created:: 20/Nov/13 8:28 PM

Updated:: 28/Dec/13 10:02 AM

Resolved:: 05/Dec/13 4:51 PM

Details

Description

Attachments

Issue Links

Activity

People

Dates

Clockify