Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42998

User selector search options: fix auto selection of unique user

    Details

    • Testing Instructions:
      Hide

      Access Users -> Permissions -> Site administrators
      Mark sure "Search option: If only one user matches the search, select them automatically" is checked.
      Search for a unique username
      One result will match and should be auto-selected.

      Show
      Access Users -> Permissions -> Site administrators Mark sure "Search option: If only one user matches the search, select them automatically" is checked. Search for a unique username One result will match and should be auto-selected.
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      master-mdl42998

      Description

      User selector search options: fix auto selection unique user as referred to in MDL-26363.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            samhemelryk Sam Hemelryk added a comment -

            Changes look spot on thanks Tim - putting this up for integration review now.

            Show
            samhemelryk Sam Hemelryk added a comment - Changes look spot on thanks Tim - putting this up for integration review now.
            Hide
            damyon Damyon Wiese added a comment -

            Thanks Tim,

            I tested on 24 and it didn't have this bug. I have integrated this to 25, 26 and master. I cherry-picked the master commit onto all branches - because your git branch for 25 was a little funky.

            Show
            damyon Damyon Wiese added a comment - Thanks Tim, I tested on 24 and it didn't have this bug. I have integrated this to 25, 26 and master. I cherry-picked the master commit onto all branches - because your git branch for 25 was a little funky.
            Hide
            tlock Tim Lock added a comment -

            Thanks Damyon.

            I've reset my 25 stable branch so it will be cleaner from now on. It had old patches I've committed on it.

            Show
            tlock Tim Lock added a comment - Thanks Damyon. I've reset my 25 stable branch so it will be cleaner from now on. It had old patches I've committed on it.
            Hide
            andyjdavis Andrew Davis added a comment -

            Works fine in master but this bug does exist in 2.4. Damyon is integrating the fix there now.

            Show
            andyjdavis Andrew Davis added a comment - Works fine in master but this bug does exist in 2.4. Damyon is integrating the fix there now.
            Hide
            damyon Damyon Wiese added a comment -

            Yep - sorry - my 24 testing must have sucked somehow. Fix added to 24.

            Show
            damyon Damyon Wiese added a comment - Yep - sorry - my 24 testing must have sucked somehow. Fix added to 24.
            Hide
            andyjdavis Andrew Davis added a comment -

            Works as described. Passing.

            Show
            andyjdavis Andrew Davis added a comment - Works as described. Passing.
            Hide
            poltawski Dan Poltawski added a comment -

            Congratulations, this change has now made its way upstream. Thanks for your contribution!

            “ Always code as if the guy who ends up maintaining your code will be a violent psychopath who knows where you live. ” - Rick Osborne

            Show
            poltawski Dan Poltawski added a comment - Congratulations, this change has now made its way upstream. Thanks for your contribution! “ Always code as if the guy who ends up maintaining your code will be a violent psychopath who knows where you live. ” - Rick Osborne

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Jan/14