Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43004

Remove second unused param from add_association api in class blog_entry

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.9
    • Component/s: Blog
    • Labels:
    • Testing Instructions:
      Hide
      1. Add the blog menu block to a course
      2. Create a new blog entry about this course
      3. Make sure the post was associated with the course
      4. Make sure there were no notices/warning/errors
      5. Grep the code for add_association and add_associations and make sure they are respectively using 1 and 0 arguments.
      6. Run blog/tests/bloglib_test.php
      Show
      Add the blog menu block to a course Create a new blog entry about this course Make sure the post was associated with the course Make sure there were no notices/warning/errors Grep the code for add_association and add_associations and make sure they are respectively using 1 and 0 arguments. Run blog/tests/bloglib_test.php
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-43004-master
    • Sprint:
      BACKEND Sprint 19

      Description

      blog_entry->add_associations($action = null)
      blog_entry->add_association($contextid, $action = null)

      $action should be removed from both apis

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              fred Frédéric Massart
              Reporter:
              ankit_frenz Ankit Agarwal
              Peer reviewer:
              Ankit Agarwal
              Integrator:
              Dan Poltawski
              Tester:
              Dan Poltawski
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/May/15