[MDL-43005] tag param in blog index page should be strictly checked - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_26_STABLE
Fixed Branches:
MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
Pull from Repository:
git://github.com/ankitagarwal/moodle.git
Pull Master Branch:
~~MDL-43005~~-master
Pull Master Diff URL:
https://github.com/ankitagarwal/moodle/compare/b58bc15...MDL-43005-master
Testing Instructions:
Hide

Enable tags and blogs at site level.

Create two tags "test" and "test1"

Create a blog with tag "test" and another with tag "test1"

Goto url blog/index.php?tag=test and make sure no error is generated and you are shown only one blog
Regression testing

Create/edit/delete/flag/add to my interest/delete from my interest/ a tag (you can do most of these from My home ► Tags ► tag name)

Add a tags block and click on a tag name and make sure no error is noticed.
Show
Enable tags and blogs at site level. Create two tags "test" and "test1" Create a blog with tag "test" and another with tag "test1" Goto url blog/index.php?tag=test and make sure no error is generated and you are shown only one blog Regression testing Create/edit/delete/flag/add to my interest/delete from my interest/ a tag (you can do most of these from My home ► Tags ► tag name) Add a tags block and click on a tag name and make sure no error is noticed.

we have

$DB->get_record_sql("SELECT * FROM {tag} WHERE ". $DB->sql_like('name', '?', false), array("%$tag%")

Which returns error like

Error: mdb->get_record() found more than one record!

    line 1427 of /lib/dml/moodle_database.php: call to debugging()

    line 43 of /blog/index.php: call to moodle_database->get_record_sql()

when we have two tags similar to each other. For example: - tag and tagtest

blocks

MDL-40040 Replace add_to_log with an event trigger - Blog

has been marked as being related by

MDL-43077 Update button on tag editting page is not display properly and action notice displayed as plain text.

Testing discovered

MDL-40040 Replace add_to_log with an event trigger - Blog

Participants:: Adrian Greeve, Ankit Agarwal, Dan Poltawski, Rossiani Wijaya, Sam Hemelryk

Component watchers:: Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie