[MDL-43016] Navigation Block not acting as previous - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_26_STABLE
Fixed Branches:
MOODLE_26_STABLE
Pull from Repository:
git://github.com/samhemelryk/moodle.git
Pull Main Branch:
43016-27
Pull Main Diff URL:
http://icodedthat.com/43016-27
Testing Instructions:
Hide

Requires a site with several categories.

Log in as an admin

Turn on editing

Edit the navigation block settings

Turn on linkcategories and save

Expand the "Courses" branch in the navigation.

Check that the course categories (loaded by AJAX) are links.
Show
Requires a site with several categories. Log in as an admin Turn on editing Edit the navigation block settings Turn on linkcategories and save Expand the "Courses" branch in the navigation. Check that the course categories (loaded by AJAX) are links.

I have just upgraded from 2.3.1... i think. I have come across a couple of problems!

Problem 1

I use to have the Courses bar always expanded, to do this in blocks\navigation\renderer.php I add

&& $item->text!="Courses ")

to line 131 so it reads

if ($item->has_children() && (!$item->forceopen || $item->collapse) && $item->text!="Courses")

{ $liclasses[] = 'collapsed'; }

I can see on the main page that the arrow is pointing down (and i have to click twice to expand) however the sub categories are not shown.

Problem 2

I have subcategories which are just one page of text and have set display categories as links to yes.

When on the main page these are not click able within the tree

However once I am in the tree and it is displaying as normal, they are clicking them send me straight to the page.

Hope someone can help

caused a regression

MDL-43152 Linting issue in shifted JavaScript

Participants:: Andrew Davis, Andrew Lyons, Dan Poltawski, jamie hibbard, Sam Hemelryk