[MDL-43045] Role name missing in security overview report - Moodle Tracker

XML

Word

Printable

Database:

Any
Affected Branches:
MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
Fixed Branches:
MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
Pull from Repository:
git://github.com/totara/moodle.git
Pull Master Branch:
master_~~MDL-43045~~
Pull Master Diff URL:
https://github.com/totara/moodle/commit/b92709db4033c91d8a3784fbcfe66c6a9bb08695
Testing Instructions:
Hide

Login as an admin

Edit the "Authenticated User" role

Set a capability that carries XSS, Config or Data loss risk to "Allow". For example "moodle/role:manage".

View the security overview report at Site Admin > Reports > Security

You should see a "Critical" risk for "Default Role for all users"

The description should say "The default user role "Authenticated User" is incorrectly defined!"
Show
Login as an admin Edit the "Authenticated User" role Set a capability that carries XSS, Config or Data loss risk to "Allow". For example "moodle/role:manage". View the security overview report at Site Admin > Reports > Security You should see a "Critical" risk for "Default Role for all users" The description should say "The default user role "Authenticated User" is incorrectly defined!"

Steps to reproduce

Edit the "Authenticated User" role
Set a capability that carries XSS, Config or Data loss risk to "Allow". For example "moodle/role:manage".
View the security overview report at Site Admin > Reports > Security Overview

What happens

You will get a Critical issue with "Default role for all users" but the description will say:

"The default user role "" is incorrectly defined!"

What should happen

The description should say "The default user role "Authenticated User" is incorrectly defined!"

For bonus points, it would be great if the detailed description printed a list of the capabilities that caused the report to fail.

is a regression caused by

MDL-8249 Localised standard role names and descriptions

Participants:: Dan Poltawski, Eloy Lafuente (stronk7), Michael de Raadt, Rajesh Taneja, Sam Hemelryk, Simon Coggins

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo