Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43068

Quiz grades become visible

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      To test this, I suggest you use three browser tabs

      • One showing the course page.
      • One showing the gradebook (the categories and items page lets you easily see whether the grade item is visible)
      • One showing the quiz that you are about to create in step 1.
      1. Create a quiz, with Review options -> Marks: all On, and Visible: Show, and save.
      2. Verify that the quiz shows up in the gradebook, and the grade item is visible.
      3. On the course page, click the eye-con to hide the quiz. Verify that the grade item becomes hidden in the gradebook.
      4. On the course page, click the eye-con to show the quiz. Verify that the grade item becomes visible in the gradebook.
      5. On the quiz setting form, set Visible: Hide and save. Verify that the grade item becomes hidden in the gradebook.
      6. On the quiz setting form, set Visible: Show and Save. Verify that the grade item becomes visible in the gradebook.
      7. Edit the quiz settings, and turn off all Review options -> Marks. Save. Verify that the grade item becomes hidden in the gradebook.
      8. Repeat the actions in steps 3-6, but now, irrespective of whether the activity is visible or hidden, the grade item should remain hidden in the gradebook, because of the review options.
      9. Repeat steps 1-6 for another graded activity (e.g. mod_assign) that does not declare FEATURE_CONTROLS_GRADE_VISIBILITY, so ensure there are no regressions.
      Show
      To test this, I suggest you use three browser tabs One showing the course page. One showing the gradebook (the categories and items page lets you easily see whether the grade item is visible) One showing the quiz that you are about to create in step 1. Create a quiz, with Review options -> Marks: all On, and Visible: Show, and save. Verify that the quiz shows up in the gradebook, and the grade item is visible. On the course page, click the eye-con to hide the quiz. Verify that the grade item becomes hidden in the gradebook. On the course page, click the eye-con to show the quiz. Verify that the grade item becomes visible in the gradebook. On the quiz setting form, set Visible: Hide and save. Verify that the grade item becomes hidden in the gradebook. On the quiz setting form, set Visible: Show and Save. Verify that the grade item becomes visible in the gradebook. Edit the quiz settings, and turn off all Review options -> Marks. Save. Verify that the grade item becomes hidden in the gradebook. Repeat the actions in steps 3-6, but now, irrespective of whether the activity is visible or hidden, the grade item should remain hidden in the gradebook, because of the review options. Repeat steps 1-6 for another graded activity (e.g. mod_assign) that does not declare FEATURE_CONTROLS_GRADE_VISIBILITY, so ensure there are no regressions.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Actually, this affects any activity that declares FEATURE_CONTROLS_GRADE_VISIBILITY.

      To reproduce.

      1. Create a new quiz with default settings.
      2. Look in the gradebook grader report, and note that the grade item for this quiz is visible. (Best to keep the grader report open in a separate tab.)
      3. Edit the quiz, and under review options, turn off all the 'Marks' check boxes and Save.
      4. In the grader report, note that the grade item is now hidden. (This is FEATURE_CONTROLS_GRADE_VISIBILITY working correctly.)
      5. In the quiz settings, set Common module settings -> Visible to Hide and Save.
      6. In the gradebook, note the grade item is still hidden. (Correct.)
      7. In the quiz settings, change Common module settings -> Visible to Show and Save.

      Actual result:

      In the gradebook, the grade item is now visible (in spite of FEATURE_CONTROLS_GRADE_VISIBILITY).

      Expected result:

      Since the marks review options are still turned off, and since the quiz should be controlling the visibility of the grade item, the grade item should still be hidden.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Jan/14