Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43069

"Submission comments" fail to expand if you hide the "file submissions" column

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Create a course with 1 student enrolled
      2. Create an assigment
      3. Log in as the student and submit the assignment
      4. Log in as teacher/admin
      5. Navigate to the assignment's Grading table
      6. Note the two grading table columns 'File submissions' and 'Submission comment'
      7. Click the expand icon on the comemnt section
      8. VERIFY: the comment section expands and you can add a comment to the submission
      9. Minimise the File submissions column
      10. VERIFY: JS errors are not visible in console
      11. Click the expand icon in the comment section
      12. VERIFY: The comment text box should appear
      Show
      Create a course with 1 student enrolled Create an assigment Log in as the student and submit the assignment Log in as teacher/admin Navigate to the assignment's Grading table Note the two grading table columns 'File submissions' and 'Submission comment' Click the expand icon on the comemnt section VERIFY: the comment section expands and you can add a comment to the submission Minimise the File submissions column VERIFY: JS errors are not visible in console Click the expand icon in the comment section VERIFY: The comment text box should appear
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Pull Master Branch:
      MDL-43069-master

      Description

      In the Assignment grading page, "Submission comments" expand when you click on the link that says "Comments (3)". Due to the limited space in the gradebook a teacher will often want to view the FirstName/Surname column, grade column and submission comments columns at the same time. (I often hide the user picture, the email address and some other less important columns)

      This works fine until you hide the "file submissions" column. All of a sudden the comments fail to expand until you "show" the "file submissions" column.

      Replication steps:

      1. Log in as teacher/admin
      2. Create an assigment
      3. Log in as a student
      4. Submit to the assignment
      5. Log in as teacher/admin
      6. Navigate to the assignment's Grading page
      7. Note that a submission and a link to add comments
      8. Minimise the File submissions column
      9. Click the link to add a comment

      Expected result: The comment text box should appear

      Actual result: The link is inactive

        Attachments

          Activity

            People

            Assignee:
            pavel.m.sokolov Pavel Sokolov
            Reporter:
            timboland Tim Atton
            Peer reviewer:
            Dan Poltawski
            Integrator:
            David Monllaó
            Tester:
            cameron1729
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            3 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              21/Dec/15