Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43071

Cannot import grades when using non-numeric scale (in certain cases)

    Details

    • Testing Instructions:
      Hide
      1. Create an assignment with non-numerical grading scale, and using the Offline feedback type
      2. Make students submit an assignment.
      3. Open grading page and choose grading action "Download grading worksheet".
      4. Open downloaded fine and add grades, make sure grades you use are defined in chosen scale.
      5. On the grading page choose "Upload grading worksheet" and upload the file with changes.
      6. Make sure that all new grades are reflected on inspection page and recorded after confirmation.
      Show
      Create an assignment with non-numerical grading scale, and using the Offline feedback type Make students submit an assignment. Open grading page and choose grading action "Download grading worksheet". Open downloaded fine and add grades, make sure grades you use are defined in chosen scale. On the grading page choose "Upload grading worksheet" and upload the file with changes. Make sure that all new grades are reflected on inspection page and recorded after confirmation.
    • Workaround:
      Hide

      In the scale definition, scale could be defined with no spaces after comma, e.g. "A,B,C,D".

      Show
      In the scale definition, scale could be defined with no spaces after comma, e.g. "A,B,C,D".
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull Master Branch:
      MDL-43071-master

      Description

      Grades importing when non-numeric scale in use does not work. The problem is in scale options conversion used in offline grades upload form and its processing. More precisely, values are not trimmed, so "A, B, C, D" scale is converted into array of:

      1 => A,
      2 => <space>B,
      3 => <space>C,
      4 => <space>D
      

      Which in turn misleads the importing check done by array_search function that finds if csv file grades matches the scale.

      Notice that using space after comma is suggested in the scale field help on scale editing page. Defining scale with no spaces is workaround, but ideally trimming needs to be implemented rather help file changes and existing scale definition fields upgrade.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Jan/14