Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43076

Activity chooser has a white bar across the bottom

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.6.1
    • Component/s: Course
    • Labels:
    • Testing Instructions:
      Hide

      Open the activity chooser in standard, clean, and any other theme you feel like testing.

      Ensure the area under the buttons is the correct colour and there is no white gap there any more (see screen shot for comparison)

      Show
      Open the activity chooser in standard, clean, and any other theme you feel like testing. Ensure the area under the buttons is the correct colour and there is no white gap there any more (see screen shot for comparison)
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-43076-master

      Description

      Something is displacing the bottom of the activity chooser.

        Gliffy Diagrams

          Activity

          Hide
          rwijaya Rossiani Wijaya added a comment -

          Hi Jason,

          The patch looks great. Please feel free to submit it for integration review.

          [y] Syntax
          [y] Whitespace
          [y] Output
          [-] Language
          [-] Databases
          [y] Testing (instructions and automated tests)
          [-] Security
          [-] Documentation
          [y] Git
          [-] Third party code
          [y] Sanity check

          Show
          rwijaya Rossiani Wijaya added a comment - Hi Jason, The patch looks great. Please feel free to submit it for integration review. [y] Syntax [y] Whitespace [y] Output [-] Language [-] Databases [y] Testing (instructions and automated tests) [-] Security [-] Documentation [y] Git [-] Third party code [y] Sanity check
          Hide
          rwijaya Rossiani Wijaya added a comment -

          Ps: The patch needs to be backported to 2.6.

          Show
          rwijaya Rossiani Wijaya added a comment - Ps: The patch needs to be backported to 2.6.
          Hide
          damyon Damyon Wiese added a comment -

          Thanks Jason,

          I verified this doesn't affect 25 and that the fix works for me on 26 and master.

          Integrated to 26 and master.

          Show
          damyon Damyon Wiese added a comment - Thanks Jason, I verified this doesn't affect 25 and that the fix works for me on 26 and master. Integrated to 26 and master.
          Hide
          dmonllao David Monllaó added a comment -

          Works as expected. Tested in master.

          Show
          dmonllao David Monllaó added a comment - Works as expected. Tested in master.
          Hide
          poltawski Dan Poltawski added a comment -

          Thanks for your contributions, this change is now upstream!

          “ If debugging is the process of removing software bugs, then programming must be the process of putting them in. ” - Edsger Dijkstra

          Show
          poltawski Dan Poltawski added a comment - Thanks for your contributions, this change is now upstream! “ If debugging is the process of removing software bugs, then programming must be the process of putting them in. ” - Edsger Dijkstra

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Jan/14