Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43083

The course page edit cog is stretched into 16x16

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.6.1
    • Component/s: Course, Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Use a browser which doesn't support SVG (e.g. turn IE8 mode on IE10)
      2. Go to a course, turn editing on
      3. Observe the edit cog icon
      • Expected result:
        • The icons is crisp (for a PNG), not distorted by the resize.
      Show
      Use a browser which doesn't support SVG (e.g. turn IE8 mode on IE10) Go to a course, turn editing on Observe the edit cog icon Expected result: The icons is crisp (for a PNG), not distorted by the resize.
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-43083-master

      Description

      1/ Use a browser which doesn't support SVG (e.g. turn IE8 mode on IE10)
      2/ Go to a course, turn editing on
      3/ Observe the edit cog icon

      Expected result:

      • You eyes are dazzled by a beautifully crisp icon expertly designed to fill those glorious 256 pixels

      Actual result:

      • A fuzzy stretched mess which will make Barbara Ramiro have a heart attack.

      It looks like we are using t/edit, but we have an appropriately sized icon in i/settings.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              barbararamiro Barbara Ramiro added a comment -

              "It looks like we are using t/edit, but we have an appropriately sized icon in i/settings." - I agree.

              Show
              barbararamiro Barbara Ramiro added a comment - "It looks like we are using t/edit, but we have an appropriately sized icon in i/settings." - I agree.
              Hide
              fred Frédéric Massart added a comment -

              This icon should not even be there... but ignore me .

              Show
              fred Frédéric Massart added a comment - This icon should not even be there... but ignore me .
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Looks good thanks Jason - moved to the integration queue.

              Show
              samhemelryk Sam Hemelryk added a comment - Looks good thanks Jason - moved to the integration queue.
              Hide
              damyon Damyon Wiese added a comment -

              Found this while testing: MDL-43183

              Show
              damyon Damyon Wiese added a comment - Found this while testing: MDL-43183
              Hide
              damyon Damyon Wiese added a comment -

              Thanks Jason, Tested and integrated. I found that this does not affect 25. With this patch I was not dazzled - the icon still looks blurry to me - just less blurry. Maybe I need more sleep.

              Integrated to 26 and master. Please start providing 26 and master branches now we are out of on-sync.

              Cheers!

              Show
              damyon Damyon Wiese added a comment - Thanks Jason, Tested and integrated. I found that this does not affect 25. With this patch I was not dazzled - the icon still looks blurry to me - just less blurry. Maybe I need more sleep. Integrated to 26 and master. Please start providing 26 and master branches now we are out of on-sync. Cheers!
              Hide
              damyon Damyon Wiese added a comment -

              Test passed (but consider me un-dazzled).

              Show
              damyon Damyon Wiese added a comment - Test passed (but consider me un-dazzled).
              Hide
              poltawski Dan Poltawski added a comment -

              Thanks for your contributions, this change is now upstream!

              “ If debugging is the process of removing software bugs, then programming must be the process of putting them in. ” - Edsger Dijkstra

              Show
              poltawski Dan Poltawski added a comment - Thanks for your contributions, this change is now upstream! “ If debugging is the process of removing software bugs, then programming must be the process of putting them in. ” - Edsger Dijkstra

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    13/Jan/14