[MDL-43109] When editing a wiki page the default value for the tags is not being populated correctly - Moodle Tracker

XML

Word

Printable

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.5.3, 2.6.1, 2.7
Fix Version/s: 2.5.5, 2.6.2
Component/s: Tags, Wiki (2.x)
Labels:
- acceptance_test_required
- ci
- netspot
- partner
- patch
- triaged

Testing Instructions:

Hide

1. Create a wiki activity
2. Add a wiki page with some tags. Save. Tags are shown.
3. Edit the wiki page and confirm that the tags that were initially entered are in the text box.

Show
1. Create a wiki activity 2. Add a wiki page with some tags. Save. Tags are shown. 3. Edit the wiki page and confirm that the tags that were initially entered are in the text box.
Workaround:

Hide

1. Re-enter the tags each time that the wiki page is edited.

Show
1. Re-enter the tags each time that the wiki page is edited.
Affected Branches:
MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
Fixed Branches:
MOODLE_25_STABLE, MOODLE_26_STABLE
Pull from Repository:
https://github.com/mdikih/moodle.git
Pull Master Branch:
~~MDL-43109~~
Pull Master Diff URL:
https://github.com/mdikih/moodle/compare/MDL-43109

When editing a wiki page the default value for the tags input box is empty even if there are tags. Saving the page will cause the tags to be deleted.

Replication steps:

Expected result: The previously added tags should appear in the editing form.

Actual result: No tags appear and the following error appears for each missing tag...

Warning: Invalid argument supplied for foreach() in D:\xampp\htdocs\master_integration\lib\form\tags.php on line 216

Discovered while testing

MDL-43673 Cover wiki page tags edition with acceptance test

Participants:: Adam Olley, Ankit Agarwal, Eloy Lafuente (stronk7), Michael de Raadt, Michael Wylde, Rossiani Wijaya

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)