Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43112

Change all "smallicon" and "iconsmall" classes to "icon-small"

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Deferred
    • Affects Version/s: 2.6
    • Fix Version/s: None
    • Component/s: HTML and CSS, Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Perform a search of all of the code and confirm that there are no instances of 'smallicon' or 'iconsmall' bar in the Skype URL.
      2. Apply the patch.
      3. Ensure that the Skype logo still shows up on the profile page of a user with Skype details filled in.
      4. Login as an administrator. Go to "Site Administration" -> "Notifications" and confirm the block show / hide icons are the same size as previously.
      5. Create a course and turn editing on. Confirm that the course icons are the same size as previously.
        ....
      Show
      Perform a search of all of the code and confirm that there are no instances of 'smallicon' or 'iconsmall' bar in the Skype URL. Apply the patch. Ensure that the Skype logo still shows up on the profile page of a user with Skype details filled in. Login as an administrator. Go to "Site Administration" -> "Notifications" and confirm the block show / hide icons are the same size as previously. Create a course and turn editing on. Confirm that the course icons are the same size as previously. ....
    • Affected Branches:
      MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-43112_master_4

      Description

      It seems that some people got mixed up and starting using "smallicon" instead of "iconsmall" for their icons.

      At some point later these two classnames started getting styled seperately.

      This has cause a few bugs where several icons in a line may have either class and look odd as a result. These bugs have generally been fixed by changing the class.

      The draft http://docs.moodle.org/dev/CSS_coding_style#Selectors states that selectors should have either a hyphen or an underscore as a separator between words. Therefore I propose that all "smallicon" and "iconsmall" classes be changed to "icon-small" in master only and '/theme/update.txt' be amended to inform contributed theme designers of the change.

        Attachments

        1. 2014_02_05_12_50_54_Course_Topics.png
          2014_02_05_12_50_54_Course_Topics.png
          3 kB
        2. 2014_02_05_13_01_45_Course_Topics.png
          2014_02_05_13_01_45_Course_Topics.png
          19 kB
        3. 2014-01-07 11_37_29-Course_ Topics_M26.png
          2014-01-07 11_37_29-Course_ Topics_M26.png
          10 kB
        4. 2014-02-05 23_36_14-Moodle GJB.png
          2014-02-05 23_36_14-Moodle GJB.png
          37 kB
        5. 2014-02-05 23_39_49-Course_ Topics.png
          2014-02-05 23_39_49-Course_ Topics.png
          34 kB
        6. after.png
          after.png
          34 kB
        7. afterburner_NEW.png
          afterburner_NEW.png
          11 kB
        8. afterburner_OLD.png
          afterburner_OLD.png
          10 kB
        9. before.png
          before.png
          32 kB
        10. blockmenu_NEW.png
          blockmenu_NEW.png
          15 kB
        11. blockmenu_OLD.png
          blockmenu_OLD.png
          13 kB
        12. context_NEW.png
          context_NEW.png
          8 kB
        13. context_OLD.png
          context_OLD.png
          10 kB
        14. courseman_NEW.png
          courseman_NEW.png
          15 kB
        15. courseman_OLD.png
          courseman_OLD.png
          15 kB
        16. coursesman_NEW.png
          coursesman_NEW.png
          53 kB
        17. mainmenu_NEW.png
          mainmenu_NEW.png
          9 kB
        18. mainmenu_OLD.png
          mainmenu_OLD.png
          8 kB
        19. menu_NEW.png
          menu_NEW.png
          23 kB
        20. menu_OLD.png
          menu_OLD.png
          23 kB
        21. socialactivites_NEW.png
          socialactivites_NEW.png
          14 kB
        22. socialactivities_OLD.png
          socialactivities_OLD.png
          13 kB

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              bawjaws David Scotson
              Peer reviewer:
              Mary Evans
              Integrator:
              Marina Glancy
              Participants:
              Component watchers:
              Amy Groshek, David Scotson, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Bas Brands
              Votes:
              5 Vote for this issue
              Watchers:
              10 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: