[MDL-43140] When submitting the form on the mnet access control page a warning is shown - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
Fixed Branches:
MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
Pull from Repository:
https://github.com/markn86/moodle.git
Pull Master Branch:
~~MDL-43140~~_master
Pull Master Diff URL:
https://github.com/markn86/moodle/compare/master...MDL-43140_master
Testing Instructions:
Hide

Visit <yoursite>/admin/mnet/access_control.php

Put any username in the form, choose 'All hosts' and set to 'Allow' and submit

Check there is no message warning about displaying page data before a redirect.

On the next page click on the 'Deny' link next to 'Allow'.

Again, check there is no message warning about displaying page data before a redirect.
Show
Visit <yoursite>/admin/mnet/access_control.php Put any username in the form, choose 'All hosts' and set to 'Allow' and submit Check there is no message warning about displaying page data before a redirect. On the next page click on the 'Deny' link next to 'Allow'. Again, check there is no message warning about displaying page data before a redirect.

You will see the following -

You should really redirect before you start page output

line 741 of /lib/outputrenderers.php: call to debugging()

line 2557 of /lib/weblib.php: call to core_renderer->redirect_message()

line 110 of /admin/mnet/access_control.php: call to redirect()

Participants:: Dan Poltawski, Eloy Lafuente (stronk7), Jason Fowler, Mark Nelson, Petr Skoda

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo