Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43159

Codechecker issues on MDL-39810 commit

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.5.4, 2.6.1
    • Component/s: Libraries
    • Labels:

      Description

      Reading about code checker in https://moodle.org/mod/forum/discuss.php?d=244921#p1062134 I realized that I made an error when submitting the MDL-39810 PR for 2.6: I've used $compat_view instead of $compatview.

      The 2.5 branch, though affected by a similar issue, should not be modified because of $supports_json_contenttype is more readable than $supportsjsoncontenttype and, at that time, I tried to mimic the new function introduced in 2.6+, core_useragent::supports_json_contenttype().

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Jan/14