Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43175

Base event JSON encoding decoding check will fail with whole float values.

    XMLWordPrintable

Details

    • 5
    • BACKEND Sprint 7

    Description

      Checks are done to ensure that the 'other' event field does not contain an object.

      If the 'other' field contains a float which is a whole number (e.g. 90) then the encoding / decoding will result in the number being returned as an integer. When the comparison is done it will fail.

      Solution: The comparison does not have to be so strict to catch if objects are being passed. '!=' will suffice.
      @see lib/classes/event/base.php line 447

      Attachments

        Issue Links

          Activity

            People

              abgreeve Adrian Greeve
              abgreeve Adrian Greeve
              Ankit Agarwal Ankit Agarwal
              Marina Glancy Marina Glancy
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Raquel Ortega, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                13/Jan/14