Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43175

Base event JSON encoding decoding check will fail with whole float values.

    XMLWordPrintable

Details

    • 5
    • BACKEND Sprint 7

    Description

      Checks are done to ensure that the 'other' event field does not contain an object.

      If the 'other' field contains a float which is a whole number (e.g. 90) then the encoding / decoding will result in the number being returned as an integer. When the comparison is done it will fail.

      Solution: The comparison does not have to be so strict to catch if objects are being passed. '!=' will suffice.
      @see lib/classes/event/base.php line 447

      Attachments

        Issue Links

          blocks

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-40921 Replace add_to_log with an event trigger - mod_workshop

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-46701 Base event JSON encoding decoding check can fail for any float values.

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              abgreeve Adrian Greeve
              abgreeve Adrian Greeve
              Ankit Agarwal Ankit Agarwal
              Marina Glancy Marina Glancy
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                13/Jan/14