Moodle
  1. Moodle
  2. MDL-43188

Backport missing beep to 2.5 and 2.4

    Details

    • Testing Instructions:
      Hide

      For this test you will need two users.

      As your primary user in your messaging settings make sure you are configured to receive popups for personal messages and that "Beep when popup notification is displayed" is ticked.

      As your second user send your primary user a personal message.

      Check that the primary user's popup is accompanied by a notification sound. You can go and play the sound in message/bell.wav to see what it sounds like.

      Untick "Beep when popup notification is displayed".

      Send another message to your primary user.

      Wait at least 2 minutes (at least 2 minutes is required between popups to avoid annoying people). Check that the primary user gets their popup without a notification sound.

      Note that this will probably not work on a computer without Quicktime installed if you are using Safari.

      Show
      For this test you will need two users. As your primary user in your messaging settings make sure you are configured to receive popups for personal messages and that "Beep when popup notification is displayed" is ticked. As your second user send your primary user a personal message. Check that the primary user's popup is accompanied by a notification sound. You can go and play the sound in message/bell.wav to see what it sounds like. Untick "Beep when popup notification is displayed". Send another message to your primary user. Wait at least 2 minutes (at least 2 minutes is required between popups to avoid annoying people). Check that the primary user gets their popup without a notification sound. Note that this will probably not work on a computer without Quicktime installed if you are using Safari.
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Story Points (Obsolete):
      5
    • Sprint:
      FRONTEND Sprint 7

      Description

      This bug is to backport the 2.6 fixes made in MDL-37962 to 2.5 and 2.4

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Andrew Davis added a comment -

            Adding 2.4 and 2.5 versions. Putting this up for peer review.

            Show
            Andrew Davis added a comment - Adding 2.4 and 2.5 versions. Putting this up for peer review.
            Hide
            Damyon Wiese added a comment -

            Hi Andrew,

            We do not modify language strings on stables, so please remove the strings changes from this patch.

            [Y] Syntax
            [Y] Whitespace
            [Y] Output
            [N] Language
            [-] Databases
            [Y] Testing (instructions and automated tests)
            [-] Security
            [-] Documentation
            [Y] Git - but it could be useful to mention the MDL of the original issue (MDL-37962) in the backport commit.
            [-] Third party code
            [Y] Sanity check (Except the language change).

            Show
            Damyon Wiese added a comment - Hi Andrew, We do not modify language strings on stables, so please remove the strings changes from this patch. [Y] Syntax [Y] Whitespace [Y] Output [N] Language [-] Databases [Y] Testing (instructions and automated tests) [-] Security [-] Documentation [Y] Git - but it could be useful to mention the MDL of the original issue ( MDL-37962 ) in the backport commit. [-] Third party code [Y] Sanity check (Except the language change).
            Hide
            Andrew Davis added a comment -

            Are you sure we don't modify strings? I thought we just didn't remove strings or change their meaning. https://moodle.org/local/chatlogs/index.php?conversationid=14476

            Show
            Andrew Davis added a comment - Are you sure we don't modify strings? I thought we just didn't remove strings or change their meaning. https://moodle.org/local/chatlogs/index.php?conversationid=14476
            Hide
            Damyon Wiese added a comment -

            My bad. We should write that down somewhere. Is it even worth changing those strings though? The new string seems a bit like developer speak.

            Show
            Damyon Wiese added a comment - My bad. We should write that down somewhere. Is it even worth changing those strings though? The new string seems a bit like developer speak.
            Hide
            Andrew Davis added a comment -

            It is a little developerish. It definitely needs to use the phrase "popup notification" as that it the phrase at the top of column when you are configuring your message settings.

            It could be "beep on popup notification" instead of "Beep when popup notification is displayed".

            Show
            Andrew Davis added a comment - It is a little developerish. It definitely needs to use the phrase "popup notification" as that it the phrase at the top of column when you are configuring your message settings. It could be "beep on popup notification" instead of "Beep when popup notification is displayed".
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Hi guys,

            this is just a message to share with you that I'm going to perform a test of the automated pre-checker against all the current issues awaiting integration (16 issues).

            So, soon, you'll get some extra comments in this issue with some information from the pre-checker. Note it's not final, but just an experiment and there are lots of things to improve, from the message itself to various false positives in the checkers. So take any report with caution, it's not 100% accurate yet.

            Please, feel free to comment any idea/objection @ MDLSITE-2662. I'll be collecting everything there.

            TIA and ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Hi guys, this is just a message to share with you that I'm going to perform a test of the automated pre-checker against all the current issues awaiting integration (16 issues). So, soon, you'll get some extra comments in this issue with some information from the pre-checker. Note it's not final, but just an experiment and there are lots of things to improve, from the message itself to various false positives in the checkers. So take any report with caution, it's not 100% accurate yet. Please, feel free to comment any idea/objection @ MDLSITE-2662 . I'll be collecting everything there. TIA and ciao
            Hide
            CiBoT added a comment -

            Results for MDL-43188

            Show
            CiBoT added a comment - Results for MDL-43188 Branch MDL-37962 _beep_24 to be integrated into upstream MOODLE_24_STABLE Executed job http://ci.stronk7.com/job/Precheck%20remote%20branch/701 Execution status: 0 Details: http://ci.stronk7.com/job/Precheck%20remote%20branch/701/artifact/work/smurf.html Branch MDL-37962 _beep_25 to be integrated into upstream MOODLE_25_STABLE Executed job http://ci.stronk7.com/job/Precheck%20remote%20branch/702 Execution status: 0 Details: http://ci.stronk7.com/job/Precheck%20remote%20branch/702/artifact/work/smurf.html
            Hide
            Sam Hemelryk added a comment -

            Thanks Andrew - this has been integrated now.

            Show
            Sam Hemelryk added a comment - Thanks Andrew - this has been integrated now.
            Hide
            Mark Nelson added a comment -

            Thanks Andrew, works as expected.

            Show
            Mark Nelson added a comment - Thanks Andrew, works as expected.
            Hide
            Damyon Wiese added a comment -

            David built a framework for behat
            At first just to test this and that
            10000+ steps written
            Sounds like we're all smitten
            And David should be smiling at that

            Thanks for reporting, patching, and testing this issue. It has been released upstream along with 64 others today.

            Show
            Damyon Wiese added a comment - David built a framework for behat At first just to test this and that 10000+ steps written Sounds like we're all smitten And David should be smiling at that Thanks for reporting, patching, and testing this issue. It has been released upstream along with 64 others today.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Agile