[MDL-43194] .jshintrc has maxlen value inconsistent with coding style - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.5.3
Fix Version/s: 2.5.4, 2.6.1
Component/s: JavaScript
Labels:
- triaged

Affected Branches:
MOODLE_25_STABLE
Fixed Branches:
MOODLE_25_STABLE, MOODLE_26_STABLE
Pull from Repository:
git://github.com/andrewnicols/moodle.git
Pull Master Branch:
~~MDL-43194~~-master
Pull Master Diff URL:
https://github.com/andrewnicols/moodle/compare/9b37cd7...MDL-43194-master

Testing Instructions:

Hide

cd to lib/yui/src/tooltip
edit js/tooltip.js

add the following to the initializer. This should give you a line length of 180 characters

        var someVar;

        someVar = '---------------------------------------------------------------------------------------------------------------------------------------------------------------';

runs shifter on the module
- confirm no errors
add an extra character to the line
runs shifter on the module
- confirm a linting error was shown about the line length

Show

cd to lib/yui/src/tooltip edit js/tooltip.js add the following to the initializer. This should give you a line length of 180 characters var someVar; someVar = '---------------------------------------------------------------------------------------------------------------------------------------------------------------'; runs shifter on the module confirm no errors add an extra character to the line runs shifter on the module confirm a linting error was shown about the line length

Description

The coding style stateth:

Aim for 132 characters if it is convenient, it is not recommended to use more than 180 characters.

The .jshintrc should enforce 180 characters. At present it is set to 150.

Attachments

Activity

People

Assignee:: Andrew Lyons

Reporter:: Andrew Lyons

Peer reviewer:: Jason Fowler

Integrator:: Sam Hemelryk

Tester:: Frédéric Massart

Participants:: Andrew Lyons, David Monllaó, Frédéric Massart, Jason Fowler, Sam Hemelryk

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 04/Dec/13 4:39 PM

Updated:: 13/Dec/13 1:49 PM

Resolved:: 13/Dec/13 1:47 PM

Fix Release Date:: 13/Jan/14