Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43194

.jshintrc has maxlen value inconsistent with coding style

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5.3
    • Fix Version/s: 2.5.4, 2.6.1
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide
      • cd to lib/yui/src/tooltip
      • edit js/tooltip.js
      • add the following to the initializer. This should give you a line length of 180 characters 

                var someVar;
        		 
                someVar = '---------------------------------------------------------------------------------------------------------------------------------------------------------------';

      • runs shifter on the module
        • confirm no errors
      • add an extra character to the line
      • runs shifter on the module
        • confirm a linting error was shown about the line length
      Show
      cd to lib/yui/src/tooltip edit js/tooltip.js add the following to the initializer. This should give you a line length of 180 characters var someVar; someVar = '---------------------------------------------------------------------------------------------------------------------------------------------------------------'; runs shifter on the module confirm no errors add an extra character to the line runs shifter on the module confirm a linting error was shown about the line length
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-43194-master
    • Pull Master Diff URL:

      Description

      The coding style stateth:

      Aim for 132 characters if it is convenient, it is not recommended to use more than 180 characters.

      The .jshintrc should enforce 180 characters. At present it is set to 150.

        Attachments

          Activity

            People

            Assignee:
            dobedobedoh Andrew Nicols
            Reporter:
            dobedobedoh Andrew Nicols
            Peer reviewer:
            Jason Fowler
            Integrator:
            Sam Hemelryk
            Tester:
            Frédéric Massart
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              13/Jan/14