Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43194

.jshintrc has maxlen value inconsistent with coding style

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • 2.5.4, 2.6.1
    • 2.5.3
    • JavaScript
    • MOODLE_25_STABLE
    • MOODLE_25_STABLE, MOODLE_26_STABLE
    • MDL-43194-master
    • Hide
      • cd to lib/yui/src/tooltip
      • edit js/tooltip.js
      • add the following to the initializer. This should give you a line length of 180 characters

                var someVar;
                someVar = '---------------------------------------------------------------------------------------------------------------------------------------------------------------';
        

      • runs shifter on the module
        • confirm no errors
      • add an extra character to the line
      • runs shifter on the module
        • confirm a linting error was shown about the line length
      Show
      cd to lib/yui/src/tooltip edit js/tooltip.js add the following to the initializer. This should give you a line length of 180 characters var someVar; someVar = '---------------------------------------------------------------------------------------------------------------------------------------------------------------'; runs shifter on the module confirm no errors add an extra character to the line runs shifter on the module confirm a linting error was shown about the line length

    Description

      The coding style stateth:

      Aim for 132 characters if it is convenient, it is not recommended to use more than 180 characters.

      The .jshintrc should enforce 180 characters. At present it is set to 150.

      Attachments

        Activity

          People

            dobedobedoh Andrew Lyons
            dobedobedoh Andrew Lyons
            Jason Fowler Jason Fowler
            Sam Hemelryk Sam Hemelryk
            Frédéric Massart Frédéric Massart
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Clockify

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.