[MDL-43218] Link to blogs appears even when blogs not enabled - Moodle Tracker

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.6
Fix Version/s: 2.4.8, 2.5.4, 2.6.1
Component/s: Navigation
Labels:
- triaged

Testing Instructions:
Hide

Click Site Admin > Advanced Features

Uncheck "Enable Blogs"

Create a course

Enrol the admin user

Enter the course

Click Navigation > Current Course > Course Name > Participants

Check there is no link to "Course Blogs"

Enable blogs again

Check that admin can see site blogs and student can see course blogs

Force separate groups in the course, enrol student in a group and make sure student can jump to his group's blog in the course only
Show
Click Site Admin > Advanced Features Uncheck "Enable Blogs" Create a course Enrol the admin user Enter the course Click Navigation > Current Course > Course Name > Participants Check there is no link to "Course Blogs" Enable blogs again Check that admin can see site blogs and student can see course blogs Force separate groups in the course, enrol student in a group and make sure student can jump to his group's blog in the course only
Affected Branches:
MOODLE_26_STABLE
Fixed Branches:
MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
Pull from Repository:
git://github.com/totara/moodle.git
Pull Master Branch:
master_~~MDL-43218~~
Pull Master Diff URL:
https://github.com/totara/moodle/commit/6911db97f03ac22959520ef6f667ea103e924784

Description

Steps to reproduce

Click Site Admin > Advanced Features
Uncheck "Enable Blogs"
Create a course
Enrol the admin user
Enter the course
Click Navigation > Current Course > Course Name > Participants

What should happen

There should be no link to "Course blogs"

What happens

There is a link to "Course blogs". Clicking it gives an error:

Blogging is disabled!

More information about this error

Debug info:
Error code: blogdisable
Stack trace:
line 463 of /lib/setuplib.php: moodle_exception thrown
line 38 of /blog/index.php: call to print_error()

Gliffy Diagrams

Attachments

Issue Links

Discovered while testing

MDL-43324 Blog do not set course context properly

Closed

has been marked as being related by

MDL-47408 Link to users blog displayed even if blogging disabled

Closed

MDL-42303 Hiding course blogs link if blogs are disabled in the platform

Closed

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Jason Fowler added a comment - 09/Dec/13 4:09 AM

The patch looks great Simon. Can we please get some testing instructions entered in before pushing this for integration?

Show

Jason Fowler added a comment - 09/Dec/13 4:09 AM The patch looks great Simon. Can we please get some testing instructions entered in before pushing this for integration?

Hide

Permalink

Simon Coggins added a comment - 09/Dec/13 6:13 AM

Oops sorry, done now.

Show

Simon Coggins added a comment - 09/Dec/13 6:13 AM Oops sorry, done now.

Hide

Permalink

Jason Fowler added a comment - 09/Dec/13 7:09 AM

Thanks for that Simon

Show

Jason Fowler added a comment - 09/Dec/13 7:09 AM Thanks for that Simon

Hide

Permalink

Marina Glancy added a comment - 10/Dec/13 6:07 AM

Hi Simon, the patch looks good.
Can I suggest a little performance improvement to add to it? It looks like a chunk of code https://github.com/totara/moodle/blob/6911db97f03ac22959520ef6f667ea103e924784/lib/navigationlib.php#L2458L2469 can also be moved into this "if" statement (and actually into the inner "if" statment). I would also not call groups_get_course_group() if we are on the frontpage because it may perform unnecessary db queries.

Show

Marina Glancy added a comment - 10/Dec/13 6:07 AM Hi Simon, the patch looks good. Can I suggest a little performance improvement to add to it? It looks like a chunk of code https://github.com/totara/moodle/blob/6911db97f03ac22959520ef6f667ea103e924784/lib/navigationlib.php#L2458L2469 can also be moved into this "if" statement (and actually into the inner "if" statment). I would also not call groups_get_course_group() if we are on the frontpage because it may perform unnecessary db queries.

Hide

Permalink

Marina Glancy added a comment - 11/Dec/13 2:30 AM

I added the commit with the change I was talking about:
https://github.com/marinaglancy/moodle/compare/master...wip-MDL-43218-master
git pull git://github.com/marinaglancy/moodle.git wip-~~MDL-43218~~-master

this also looks like a bug that needs backporting

Show

Marina Glancy added a comment - 11/Dec/13 2:30 AM I added the commit with the change I was talking about: https://github.com/marinaglancy/moodle/compare/master...wip-MDL-43218-master git pull git://github.com/marinaglancy/moodle.git wip- MDL-43218 -master this also looks like a bug that needs backporting

Hide

Permalink

Sam Hemelryk added a comment - 11/Dec/13 2:42 AM

Thanks Simon + Marina, nice fix and improvement!

Cheers
Sam

Show

Sam Hemelryk added a comment - 11/Dec/13 2:42 AM Thanks Simon + Marina, nice fix and improvement! Cheers Sam

Hide

Permalink

David Monllaó added a comment - 11/Dec/13 3:53 AM

It passes, tested in 25 and master.

A couple of things I've noticed, not part of this issue:

The link text is always the same, Course blogs both when is pointing to a course-level or group-level blogs
After clicking on Course blogs the next page shows a Blog about this Course both when is pointing to a course-level or group-level blogs

Show

David Monllaó added a comment - 11/Dec/13 3:53 AM It passes, tested in 25 and master. A couple of things I've noticed, not part of this issue: The link text is always the same, Course blogs both when is pointing to a course-level or group-level blogs After clicking on Course blogs the next page shows a Blog about this Course both when is pointing to a course-level or group-level blogs

Hide

Permalink

Marina Glancy added a comment - 11/Dec/13 3:56 AM

David, I already created issue ~~MDL-43324~~ about wrong context on course blog page

Show

Marina Glancy added a comment - 11/Dec/13 3:56 AM David, I already created issue MDL-43324 about wrong context on course blog page

Hide

Permalink

Simon Coggins added a comment - 11/Dec/13 11:59 PM - edited

Thanks Marina, I go away for a few days and it's all fixed

Show

Simon Coggins added a comment - 11/Dec/13 11:59 PM - edited Thanks Marina, I go away for a few days and it's all fixed

Hide

Permalink

Marina Glancy added a comment - 12/Dec/13 12:23 AM

Also there is a workaround for this problem - just to revoke the capability to view blogs from all roles

Show

Marina Glancy added a comment - 12/Dec/13 12:23 AM Also there is a workaround for this problem - just to revoke the capability to view blogs from all roles

Hide

Permalink

Sam Hemelryk added a comment - 13/Dec/13 5:47 AM

Thanks for the code, its now upstream!

Heres a fun trick to try in the spirit of Friday the 13th.
I hear if you stand in front a mirror, alone, in the dark, and say "Oracle" three times Petr Skoka will appear in the mirror and you'll see him deleting the Oracle driver from Moodle.

Show

Sam Hemelryk added a comment - 13/Dec/13 5:47 AM Thanks for the code, its now upstream! Heres a fun trick to try in the spirit of Friday the 13th. I hear if you stand in front a mirror, alone, in the dark, and say "Oracle" three times Petr Skoka will appear in the mirror and you'll see him deleting the Oracle driver from Moodle.

Hide

Permalink

Gerald Hartwig added a comment - 03/Feb/14 10:09 AM

Hey,

additional to this tracker entry:

Link to user blogs are visible in user list, in spite of disbaling the blogs in website-administration.

1.) Website-Administration > uncheck blogs
2.) login as student, go into a course
3.) navigatrion > current course > participants
4.) user list : user details (not: brief)
5.) links to user blogs are visible

Using: Moodle 2.6.1

Greetings
Gerald

Show

Gerald Hartwig added a comment - 03/Feb/14 10:09 AM Hey, additional to this tracker entry: Link to user blogs are visible in user list, in spite of disbaling the blogs in website-administration. 1.) Website-Administration > uncheck blogs 2.) login as student, go into a course 3.) navigatrion > current course > participants 4.) user list : user details (not: brief) 5.) links to user blogs are visible Using: Moodle 2.6.1 Greetings Gerald

Hide

Permalink

Marina Glancy added a comment - 03/Feb/14 10:19 AM

Hello Gerald, this issue is already closed. Can you please create another issue in tracker if you think that there is more work to do.
Thank you

Show

Marina Glancy added a comment - 03/Feb/14 10:19 AM Hello Gerald, this issue is already closed. Can you please create another issue in tracker if you think that there is more work to do. Thank you

Hide

Permalink

Paul Holden added a comment - 24/Sep/14 9:38 PM

Hi Marina Glancy, I've also noticed the same thing as described by Gerald Hartwig; I've created ~~MDL-47408~~ to look at it

Show

Paul Holden added a comment - 24/Sep/14 9:38 PM Hi Marina Glancy , I've also noticed the same thing as described by Gerald Hartwig ; I've created MDL-47408 to look at it

People

Assignee:

Simon Coggins

Reporter:

Simon Coggins

Peer reviewer:

Jason Fowler

Integrator:

Sam Hemelryk

Tester:

David Monllaó

Participants:

David Monllaó, Gerald Hartwig, Jason Fowler, Marina Glancy, Paul Holden, Sam Hemelryk, Simon Coggins

Votes:

0 Vote for this issue

Watchers:

8 Start watching this issue

Dates

Created:

05/Dec/13 7:19 AM

Updated:

24/Sep/14 9:38 PM

Resolved:

13/Dec/13 5:47 AM

Fix Release Date:

13/Jan/14