[MDL-43232] Migrate moodle-backup-confirmcancel to Shifter - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_26_STABLE
Fixed Branches:
MOODLE_27_STABLE
Pull from Repository:
git://github.com/andrewnicols/moodle.git
Pull Main Branch:
~~MDL-43232~~-master
Pull Main Diff URL:
https://github.com/andrewnicols/moodle/compare/9b37cd7...MDL-43232-master
Testing Instructions:
Hide

Start a new backup

Click the cancel button

Confirm that you're presented with a cancellation dialogue

Confirm the wording matches what you would expect

Choose to Cancel

Confirm that you're navigated away

Start it again

Choose Cancel

Choose to Stay

Confirm that the dialogue closes

NOTE: There is a bug in moodle-core-notification which seems to mean that the second time the confirmation dialogue is created on the same page load, it is not visible on screen. Opening this as a separate issue.
Show
Start a new backup Click the cancel button Confirm that you're presented with a cancellation dialogue Confirm the wording matches what you would expect Choose to Cancel Confirm that you're navigated away Start it again Choose Cancel Choose to Stay Confirm that the dialogue closes NOTE: There is a bug in moodle-core-notification which seems to mean that the second time the confirmation dialogue is created on the same page load, it is not visible on screen. Opening this as a separate issue.

Migrate moodle-backup-confirmcancel to use Shifter

Discovered while testing

MDL-43234 moodle-core-dialogue overwrites supplied configuration

MDL-43334 Headers output before redirect when cancelling a backup