Loading...

XML

Word

Printable

Affected Branches:
MOODLE_26_STABLE
Fixed Branches:
MOODLE_26_STABLE
Pull from Repository:
git://github.com/andrewnicols/moodle.git
Pull Main Branch:
~~MDL-43234~~-master
Pull Main Diff URL:
https://github.com/andrewnicols/moodle/compare/c36a240...MDL-43234-master
Testing Instructions:
Hide

Try opening a variety of Moodle dialogues, including:

backup/restore cancellation confirmation;

activity chooser

file picker

enrol dialogue

keyboard move

open each, then close it, and open it a few more times.

Confirm that it appears the same each time**

The place I noticed this was the backup/restore cancellation with the location being confused on subsequent loads.
Show
Try opening a variety of Moodle dialogues, including: backup/restore cancellation confirmation; activity chooser file picker enrol dialogue keyboard move open each, then close it, and open it a few more times. Confirm that it appears the same each time** The place I noticed this was the backup/restore cancellation with the location being confused on subsequent loads.

As seen with the backup confirmcancel dialogue. If you first choose to stay, and then re-open it, the dialogue is display off screen.

This turns out to be because the configuration is passed by reference, and we then modify the values - e.g.:

    config.center =     config.centered && true;

    config.centered =   false;

This means that:

the first time that the dialogue is displayed, it will be follow the value of config.centered;
then config.centered is set to false;
any subsequent time it is called, config.centered is now false, therefore config.center is also false

Testing discovered

MDL-43232 Migrate moodle-backup-confirmcancel to Shifter

Participants:: Andrew Davis, Andrew Lyons, cameron1729, Damyon Wiese, Petr Skoda, Sam Hemelryk