Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43236

Behat grammar improvements

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Test 1

      1. Check that behat master passes (you can ask integrators for the CI server status)

      Test 2

      1. From dirroot, php admin/tool/behat/cli/init.php
      2. Ensure you didn't set $CFG->behat_usedeprecated = true; in your config.php
      3. Write a new .feature file using one of the deprecated methods (https://tracker.moodle.org/browse/MDL-43236?focusedCommentId=272647&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-272647)
      4. From dirroot type php admin/tool/behat/util.php --enable
      5. Run vendor/bin/behat --config /asd/asd/asd/as/behat/behat.yml /absolute/path/to/the/feature/file/you/created/file.feature
      6. You SHOULD see a failure stating that that step was deprecated and proposing you an alternative
      7. Set $CFG->behat_usedeprecated = true; in your config.php
      8. Run vendor/bin/behat --config /asd/asd/asd/as/behat/behat.yml /absolute/path/to/the/feature/file/you/created/file.feature
      9. It SHOULD pass
      Show
      Test 1 Check that behat master passes (you can ask integrators for the CI server status) Test 2 From dirroot, php admin/tool/behat/cli/init.php Ensure you didn't set $CFG->behat_usedeprecated = true; in your config.php Write a new .feature file using one of the deprecated methods ( https://tracker.moodle.org/browse/MDL-43236?focusedCommentId=272647&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-272647 ) From dirroot type php admin/tool/behat/util.php --enable Run vendor/bin/behat --config /asd/asd/asd/as/behat/behat.yml /absolute/path/to/the/feature/file/you/created/file.feature You SHOULD see a failure stating that that step was deprecated and proposing you an alternative Set $CFG->behat_usedeprecated = true; in your config.php Run vendor/bin/behat --config /asd/asd/asd/as/behat/behat.yml /absolute/path/to/the/feature/file/you/created/file.feature It SHOULD pass
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-43236_master
    • Pull Master Diff URL:

      Description

      Behat has some slight grammar errors with the word exists.

      Update steps/features so combinations of should and does with the word exist does not have a plural

      Correct: "X should|does (not) exist"
      Incorrect: "X should|does (not) exists"

        Attachments

          Issue Links

          blocks

          Improvement - An enhancement to an existing Moodle feature. MDL-43682 Rewrite loglive report to use the new logging api

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed
          has a non-specific relationship to

          Improvement - An enhancement to an existing Moodle feature. MDL-44337 behat test for glossary categories

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has been marked as being related by

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-42862 Remove behat deprecated step definitions

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is blocked by

          Improvement - An enhancement to an existing Moodle feature. MDL-43738 Normalize behat fields getters and setters

          • Major - Major loss of function, incorrect output
          • Closed

          Improvement - An enhancement to an existing Moodle feature. MDL-43837 Behat suite tunning

          • Major - Major loss of function, incorrect output
          • Closed

            Activity

              People

              Assignee:
              dmonllao David Monllaó
              Reporter:
              damyon Damyon Wiese
              Peer reviewer:
              Frédéric Massart
              Integrator:
              Dan Poltawski
              Tester:
              Rajesh Taneja
              Participants:
              Component watchers:
              Andrew Nicols, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Mar/14