Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43265

Quiz question name error when text is over 255 chars

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5.4, 2.6, 2.7
    • Fix Version/s: 2.5.5, 2.6.2
    • Component/s: Quiz
    • Labels:
    • Testing Instructions:
      Hide

      1. Go to any question type.
      2. Create/Edit a new question.
      3. Try to enter name of Question greater than 255 chars.
      4. See that the text box doesnt take input more than 255 chars.

      Show
      1. Go to any question type. 2. Create/Edit a new question. 3. Try to enter name of Question greater than 255 chars. 4. See that the text box doesnt take input more than 255 chars.
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-43265_new

      Description

      The "text input tag" for name is not limited to 255 chars causing an exception: Error writing to database if text exceeds 255 chars.

      table:mdl_question, field: name is limited to varchar(255)

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            plamen.vassilev Plamen Ivanov Vassilev added a comment -

            Since I am unclear with the workflow to publish the changes for review this is the patch: https://github.com/plamenivanov/moodle-Quiz-Question_name-MDL-43265.git

            Show
            plamen.vassilev Plamen Ivanov Vassilev added a comment - Since I am unclear with the workflow to publish the changes for review this is the patch: https://github.com/plamenivanov/moodle-Quiz-Question_name-MDL-43265.git
            Hide
            timhunt Tim Hunt added a comment -

            http://docs.moodle.org/dev/Process should explain the process, but it may not make sense until you have worked through it a few times. Looking at what happens with some other issues on the "Integration dashboard" https://tracker.moodle.org/secure/Dashboard.jspa?selectPageId=11350 might also help you understand the process.

            The fix itself looks good, so it is just a matter of getting it submitted properly.

            Show
            timhunt Tim Hunt added a comment - http://docs.moodle.org/dev/Process should explain the process, but it may not make sense until you have worked through it a few times. Looking at what happens with some other issues on the "Integration dashboard" https://tracker.moodle.org/secure/Dashboard.jspa?selectPageId=11350 might also help you understand the process. The fix itself looks good, so it is just a matter of getting it submitted properly.
            Hide
            jacks92 Jayesh Anandani added a comment -

            All branches and testing code updated.

            thanks.

            Show
            jacks92 Jayesh Anandani added a comment - All branches and testing code updated. thanks.
            Hide
            timhunt Tim Hunt added a comment -

            Look at the compare URLs. I think you need to push master, MOODLE_26_STABLE branches, etc to your github.

            Show
            timhunt Tim Hunt added a comment - Look at the compare URLs. I think you need to push master, MOODLE_26_STABLE branches, etc to your github.
            Hide
            timhunt Tim Hunt added a comment -

            Thanks Jayesh. Submitting for integration.

            Show
            timhunt Tim Hunt added a comment - Thanks Jayesh. Submitting for integration.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            cibot CiBoT added a comment -

            Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

            Show
            cibot CiBoT added a comment - Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated (25, 26 & master), thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated (25, 26 & master), thanks!
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            grrr, didn't see an extra, incorrect ")" in the one liner.... fixing it.

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - grrr, didn't see an extra, incorrect ")" in the one liner.... fixing it.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Tim - tested and passed

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Tim - tested and passed
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            I claim to be a simple individual
            liable to err like any other fellow mortal.
            I own, however, that I have humility enough
            to confess my errors and to retrace my steps.

            Mahatma Gandhi

            Your awesome code has met upstream, closing, thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - I claim to be a simple individual liable to err like any other fellow mortal. I own, however, that I have humility enough to confess my errors and to retrace my steps. Mahatma Gandhi Your awesome code has met upstream, closing, thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Mar/14