Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43281

blockregion.js doesn't recover properly after not finding region node

    XMLWordPrintable

Details

    • MOODLE_25_STABLE
    • MOODLE_25_STABLE, MOODLE_26_STABLE
    • MDL-43281-master
    • Hide

      As Mark suggests, this is difficult to test without introducing a deliberately broken theme. As Mark also says, the fix is fairly obvious. These instructions primarily check for regressions.

      • Run behat
      • Play with blocks in editing mode
      Show
      As Mark suggests, this is difficult to test without introducing a deliberately broken theme. As Mark also says, the fix is fairly obvious. These instructions primarily check for regressions. Run behat Play with blocks in editing mode
    • 3
    • FRONTEND Sprint 7

    Description

      I believe this only happens on older themes that are not using the newer code to print out block regions. So, steps to reproduce could be tricky, but the problem is obvious in the code.

      Basically what is happening is if the block region JS fails to find the block region, then it attempts to create and add the region node to the page. This works fine except it doesn't re-fresh the local node variable.

      Attachments

        Issue Links

          will help resolve

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-41551 Block drag/drop broken for clean theme on /my

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

          Activity

            People

              dobedobedoh Andrew Lyons
              bushido Mark Nielsen
              Petr Skoda Petr Skoda
              Sam Hemelryk Sam Hemelryk
              Ankit Agarwal Ankit Agarwal
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                13/Jan/14