Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43281

blockregion.js doesn't recover properly after not finding region node

XMLWordPrintable

    • MOODLE_25_STABLE
    • MOODLE_25_STABLE, MOODLE_26_STABLE
    • MDL-43281-master
    • Hide

      As Mark suggests, this is difficult to test without introducing a deliberately broken theme. As Mark also says, the fix is fairly obvious. These instructions primarily check for regressions.

      • Run behat
      • Play with blocks in editing mode
      Show
      As Mark suggests, this is difficult to test without introducing a deliberately broken theme. As Mark also says, the fix is fairly obvious. These instructions primarily check for regressions. Run behat Play with blocks in editing mode
    • 3
    • FRONTEND Sprint 7

      I believe this only happens on older themes that are not using the newer code to print out block regions. So, steps to reproduce could be tricky, but the problem is obvious in the code.

      Basically what is happening is if the block region JS fails to find the block region, then it attempts to create and add the region node to the page. This works fine except it doesn't re-fresh the local node variable.

        1. blockregion.patch
          0.6 kB

            dobedobedoh Andrew Lyons
            bushido Mark Nielsen
            Petr Skoda Petr Skoda
            Sam Hemelryk Sam Hemelryk
            Ankit Agarwal Ankit Agarwal
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.