Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43281

blockregion.js doesn't recover properly after not finding region node

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      As Mark suggests, this is difficult to test without introducing a deliberately broken theme. As Mark also says, the fix is fairly obvious. These instructions primarily check for regressions.

      • Run behat
      • Play with blocks in editing mode
      Show
      As Mark suggests, this is difficult to test without introducing a deliberately broken theme. As Mark also says, the fix is fairly obvious. These instructions primarily check for regressions. Run behat Play with blocks in editing mode
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull Master Branch:
      MDL-43281-master
    • Story Points:
      3
    • Sprint:
      FRONTEND Sprint 7

      Description

      I believe this only happens on older themes that are not using the newer code to print out block regions. So, steps to reproduce could be tricky, but the problem is obvious in the code.

      Basically what is happening is if the block region JS fails to find the block region, then it attempts to create and add the region node to the page. This works fine except it doesn't re-fresh the local node variable.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              bushido Mark Nielsen
              Peer reviewer:
              Petr Skoda
              Integrator:
              Sam Hemelryk
              Tester:
              Ankit Agarwal
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Jan/14