Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43295

Debugging warning on saving an online text submission with an uploaded image.

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Critical
    • 2.6.1, 2.7
    • 2.6
    • Events API
    • None
    • MOODLE_26_STABLE
    • MOODLE_26_STABLE, MOODLE_27_STABLE
    • wip-MDL-43295-master
    • Hide

      Pre-requisites

      • Some students enrolled in a course.
      • Developer level debugging must be enabled.

      Testing

      1. Create an assignment (mod_assign).
        • Make sure that the submission type is "Online text" only (untick "File submissions").
      2. Log in as a student.
      3. Make a submission for the assignment. Make sure to embed an image into the online text.
      4. When you click "Save changes" make sure that no debugging message is shown.

      Unit tests

      • Run phpunit mod/assign/submission/onlinetext/tests/events_test.php and check that they pass.
      Show
      Pre-requisites Some students enrolled in a course. Developer level debugging must be enabled. Testing Create an assignment (mod_assign). Make sure that the submission type is "Online text" only (untick "File submissions"). Log in as a student. Make a submission for the assignment. Make sure to embed an image into the online text. When you click "Save changes" make sure that no debugging message is shown. Unit tests Run phpunit mod/assign/submission/onlinetext/tests/events_test.php and check that they pass.
    • 13
    • BACKEND Sprint 8

    Description

      Warning:

      Before calling format_text(), the content must be processed with file_rewrite_pluginfile_urls() (line 144 of /mod/assign/submission/onlinetext/locallib.php).

      It makes no sense to me that we are calling format_text and storing the result as 'content' in the event. IMO we should store the raw text and format instead. I think this should be a "rule" for all events.

      Attachments

        Issue Links

          blocks

          Improvement - An enhancement to an existing Moodle feature. MDL-34432 Assignment -teachers can no longer comment inline on online text

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed
          will be (partly) resolved by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-43289 Events for submission

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              abgreeve Adrian Greeve
              damyon Damyon Wiese
              Damyon Wiese Damyon Wiese
              Marina Glancy Marina Glancy
              Rajesh Taneja Rajesh Taneja
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                13/Jan/14