Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43323

Lazily load moodle-core-tooltip dependencies

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7
    • Fix Version/s: 2.7
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      With the JS console open:

      • Open the login page
        • Confirm that there was no warning that moodle-core-notification has been deprecated
      • Click on the help dialogue
        • Confirm it appears as expected
      • Edit help_ajax.php and throw a new moodle_exception somewhere before the json_encode is output
      • Refresh the page
      • Click the help icon again
        • Confirm that the exception dialogue is shown
        • Confirm non warning about moodle-core-notification being deprecated in the console
      • Edit help_ajax.php again and remove the exception. Add an echo with some random content instead.
      • Click the help icon again
        • Confirm that the exception dialogue is shown
        • Confirm non warning about moodle-core-notification being deprecated in the console
      Show
      With the JS console open: Open the login page Confirm that there was no warning that moodle-core-notification has been deprecated Click on the help dialogue Confirm it appears as expected Edit help_ajax.php and throw a new moodle_exception somewhere before the json_encode is output Refresh the page Click the help icon again Confirm that the exception dialogue is shown Confirm non warning about moodle-core-notification being deprecated in the console Edit help_ajax.php again and remove the exception. Add an echo with some random content instead. Click the help icon again Confirm that the exception dialogue is shown Confirm non warning about moodle-core-notification being deprecated in the console
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull Master Branch:
      MDL-43323-master
    • Story Points:
      5
    • Sprint:
      FRONTEND Sprint 7

      Description

      We don't need all of moodle-core-dialogue in all cases and should lazily load those dependencies until we do actually need them.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              dobedobedoh Andrew Nicols
              Peer reviewer:
              Sam Hemelryk
              Integrator:
              Dan Poltawski
              Tester:
              Frédéric Massart
              Participants:
              Component watchers:
              Andrew Nicols, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/May/14