Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43325

Some dialogues (exceptions, ajaxexception, confirm, etc) are no longer shown when instantiated

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Major
    • 2.6.1
    • 2.6
    • JavaScript
    • MOODLE_26_STABLE
    • MOODLE_26_STABLE
    • MDL-43325-master
    • Hide

      Run full behat suite

      • Edit help_ajax.php
      • At some point after config.php has been included, throw a new moodle_exception
      • Open the login page in the browser
      • Click on the help icon
        • Confirm that the ajaxException dialogue was displayed
      • Remove the moodle_exception
      • echo out some random junk at the end of the file
      • Click on the help icon again
        • Confirm that an exception dialogue was displayed
      • Edit enrol/yui/rolemanager/rolemanager.js
        • Find the visible : true line, and remove it
      • Login to moodle as an admin/manager/teacher
      • Navigate to a course's enrol page
      • Remove a role from a user
        • Confirm that you get a confirmation dialogue
      • Navigate to a course and turn editing on
      • Open the activity chooser
        • Confirm that it was shown as expected
      • Cancel the activity chooser
      • Reopen it
        • Confirm that it was shown again
      • Add a new assignment instance
      • As a student, upload a PDF to it
        • Confirm that the filepicker was not displayed until you requested it
      • As a tutor, Launch the PDF editor
        • Confirm that no new dialogues are visible initially
      • Click on the comment search button
        • Confirm that the dialogue is now visible

      We have few examples of M.core.alert in core, and these are very difficult to force a display of so skipping testing for these.

      Show
      Run full behat suite Edit help_ajax.php At some point after config.php has been included, throw a new moodle_exception Open the login page in the browser Click on the help icon Confirm that the ajaxException dialogue was displayed Remove the moodle_exception echo out some random junk at the end of the file Click on the help icon again Confirm that an exception dialogue was displayed Edit enrol/yui/rolemanager/rolemanager.js Find the visible : true line, and remove it Login to moodle as an admin/manager/teacher Navigate to a course's enrol page Remove a role from a user Confirm that you get a confirmation dialogue Navigate to a course and turn editing on Open the activity chooser Confirm that it was shown as expected Cancel the activity chooser Reopen it Confirm that it was shown again Add a new assignment instance As a student, upload a PDF to it Confirm that the filepicker was not displayed until you requested it As a tutor, Launch the PDF editor Confirm that no new dialogues are visible initially Click on the comment search button Confirm that the dialogue is now visible We have few examples of M.core.alert in core, and these are very difficult to force a display of so skipping testing for these.
    • 3
    • FRONTEND Sprint 7

    Description

      They used to be... and should still be.
      We were previously ignoring the 'visible' field. We now respect it (sanity prevails), but should be changing the default to true for all but the base dialogue.

      Note, although everywhere that we have confirm and alert dialogues in core, we already forcibly call show, or we set visible: true in it's config, but this is still a change from the API which has existed for quite some time so should be fixed.

      Exceptions and ajaxExceptions no longer display at all in many places.

      Attachments

        Issue Links

          blocks

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-43262 Move dialogue default overrides to attributes

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-34182 Invalid JSON output on filepicker when repository plugins output invalid content

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed

          Improvement - An enhancement to an existing Moodle feature. MDL-43323 Lazily load moodle-core-tooltip dependencies

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-43370 Confirm dialog default width does not work well on mobile

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is a regression caused by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-41188 Mobile: when closing file picker, the page should be re-centred on the file manager (if you were using the file manager)

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              dobedobedoh Andrew Lyons
              dobedobedoh Andrew Lyons
              Damyon Wiese Damyon Wiese
              Sam Hemelryk Sam Hemelryk
              Sam Hemelryk Sam Hemelryk
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                13/Jan/14