[MDL-43337] limitfrom, limitnumber addition to get_enrolled_users/get_enrolled_users_with_capability missed a break - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.5.4, 2.6.1, 2.7
Fix Version/s: 2.5.5, 2.6.2
Component/s: Web Services
Labels:
- ci
- triaged

Testing Instructions:

Hide

Run all phpunit tests

Show
Run all phpunit tests
Affected Branches:
MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
Fixed Branches:
MOODLE_25_STABLE, MOODLE_26_STABLE
Pull from Repository:
git://github.com/FMCorz/moodle.git
Pull Master Branch:
~~MDL-43337~~-master
Pull Master Diff URL:
https://github.com/FMCorz/moodle/compare/974c2cd...MDL-43337-master

Description

'limitfrom' and 'limitnumber' options were added in commit 3ed74dd1 in enrol/externallib.php line 116. This added two cases to switch but only one break; As a result 'userfields' case now misses a break and if userfields option is used in addition to limitfrom the limitfrom will get value 0 every time.

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

missing_break_added.patch
0.9 kB
11/Dec/13 4:53 PM

Activity

People

Assignee:: Frédéric Massart

Reporter:: Mikko Rantanen

Peer reviewer:: Petr Skoda

Integrator:: Eloy Lafuente (stronk7)

Tester:: Eloy Lafuente (stronk7)

Participants:: Amanpreet Singh, CiBoT, Eloy Lafuente (stronk7), Frédéric Massart, Mikko Rantanen, Petr Skoda

Component watchers:: Juan Leyva, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 11/Dec/13 4:38 PM

Updated:: 21/Feb/14 4:03 AM

Resolved:: 21/Feb/14 4:03 AM

Fix Release Date:: 10/Mar/14