Moodle
  1. Moodle
  2. MDL-43347

"Drop the lowest" on the Edit Category page should be a text input, not a dropdown

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.5, 2.8
    • Fix Version/s: 2.6.4, 2.7.1
    • Component/s: Gradebook
    • Labels:
    • Testing Instructions:
      Hide

      Drop lowest

      1. Create a course.
      2. In the gradebook, create a grade category.
      3. Go to Edit categories and items > Full view.
      4. Enter "44" for "Drop the lowest" on the category you created. Save your changes.
      5. Verify that the setting remained.
      6. Go to Edit categories and items > Simple view.
      7. Click the edit icon for the category you created. Verify that "Drop the lowest" is set to 44. Change it to 45. Save.
      8. Return the Full view. Verify that the setting is 45.

      Keep highest

      1. Enable Keep highest by unforcing the setting in Site Administration > Grades > Grade category settings.
      2. Create a course.
      3. In the gradebook, create a grade category.
      4. Go to Edit categories and items > Full view.
      5. Enter "44" for "Keep the highest" on the category you created. Save your changes.
      6. Verify that the setting remained.
      7. Go to Edit categories and items > Simple view.
      8. Click the edit icon for the category you created. Verify that "Keep the highest" is set to 44. Change it to 45. Save.
      9. Return the Full view. Verify that the setting is 45.
      Show
      Drop lowest Create a course. In the gradebook, create a grade category. Go to Edit categories and items > Full view. Enter "44" for "Drop the lowest" on the category you created. Save your changes. Verify that the setting remained. Go to Edit categories and items > Simple view. Click the edit icon for the category you created. Verify that "Drop the lowest" is set to 44. Change it to 45. Save. Return the Full view. Verify that the setting is 45. Keep highest Enable Keep highest by unforcing the setting in Site Administration > Grades > Grade category settings. Create a course. In the gradebook, create a grade category. Go to Edit categories and items > Full view. Enter "44" for "Keep the highest" on the category you created. Save your changes. Verify that the setting remained. Go to Edit categories and items > Simple view. Click the edit icon for the category you created. Verify that "Keep the highest" is set to 44. Change it to 45. Save. Return the Full view. Verify that the setting is 45.
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull from Repository:
    • Pull 2.6 Branch:
    • Pull 2.7 Branch:
    • Pull Master Branch:
      MDL-43347-master

      Description

      On the Gradebook Categories and Items Full View screen, the value for "Drop the lowest" grades is set with a text input box. On the Edit Category screen, however, it's set with a dropdown. They should match, especially since the drop-down limits the number of items a teacher can drop to 20.

        Gliffy Diagrams

          Activity

          Hide
          Charles Fulton added a comment -

          This change replaces the drop-down with a text field. Note that the options array is used by keephigh.

          Show
          Charles Fulton added a comment - This change replaces the drop-down with a text field. Note that the options array is used by keephigh.
          Hide
          CiBoT added a comment -
          Show
          CiBoT added a comment - Results for MDL-43347 Remote repository: https://github.com/mackensen/moodle Remote branch MDL-43347 -master to be integrated into upstream master Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/4303 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/4303/artifact/work/smurf.html
          Hide
          Mark Nelson added a comment -

          Hi Charles,

          Thanks a lot for working on this.

          The change looks great, thanks again. I am just wondering wouldn't it make sense to remove the $options array and convert the highest to a text field as well?

          Show
          Mark Nelson added a comment - Hi Charles, Thanks a lot for working on this. The change looks great, thanks again. I am just wondering wouldn't it make sense to remove the $options array and convert the highest to a text field as well?
          Hide
          Charles Fulton added a comment -

          Hi Mark, it probably does for consistency. I've pushed up a second commit.

          Show
          Charles Fulton added a comment - Hi Mark, it probably does for consistency. I've pushed up a second commit.
          Hide
          Mark Nelson added a comment -

          Thanks for your hard work Charles, looks good.

          Can you backport to 2.7 and 2.6 and also add testing instructions for the 'keephigh' field?

          Cheers!

          Show
          Mark Nelson added a comment - Thanks for your hard work Charles, looks good. Can you backport to 2.7 and 2.6 and also add testing instructions for the 'keephigh' field? Cheers!
          Hide
          Charles Fulton added a comment -

          Thanks Mark, updated. It occurs to me that the defaults in the admin settings are still dropdowns. I'm not sure that's an issue; those are reasonable defaults and wouldn't interact with a user setting.

          Show
          Charles Fulton added a comment - Thanks Mark, updated. It occurs to me that the defaults in the admin settings are still dropdowns. I'm not sure that's an issue; those are reasonable defaults and wouldn't interact with a user setting.
          Hide
          Mark Nelson added a comment -

          Hi Charles,

          Thanks adding the additional testing instructions. I think it is fine to leave the settings as a drop down. Thanks for pointing that out.

          Submitting to integration.

          Show
          Mark Nelson added a comment - Hi Charles, Thanks adding the additional testing instructions. I think it is fine to leave the settings as a drop down. Thanks for pointing that out. Submitting to integration.
          Hide
          CiBoT added a comment -

          Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

          Show
          CiBoT added a comment - Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!
          Hide
          Sam Hemelryk added a comment -

          Thanks Charles this has been integrated now.

          Show
          Sam Hemelryk added a comment - Thanks Charles this has been integrated now.
          Hide
          Andrew Nicols added a comment -

          Thanks Charles,

          This is passing the described tests. I played around a little more too and all seems well.

          Cheers,

          Andrew

          Show
          Andrew Nicols added a comment - Thanks Charles, This is passing the described tests. I played around a little more too and all seems well. Cheers, Andrew
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Just in time for incoming releases, well done. And big thanks!

          We must plan for freedom,
          and not only for security,
          if for no other reason than that
          only freedom can make security secure

          –  Karl Popper

          Show
          Eloy Lafuente (stronk7) added a comment - Just in time for incoming releases, well done. And big thanks! We must plan for freedom, and not only for security, if for no other reason than that only freedom can make security secure –  Karl Popper

            People

            • Votes:
              7 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: