Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43348

html <nav> element on the wrong content in bootstrapbase

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Apply the patch.
      2. Select the Clean theme.
      3. Go to Site Administration > Notifications and confirm that the page displays correctly (columns2.php test).
      4. Log out and confirm that the login page displays correctly (columns1.php test).
      5. Log back in.
      6. Create a course and confirm that the course displays correctly (column3.php test).
      7. Go to Site Administration -> Reports -> Live Logs and click on 'Live logs from the past hour', confirm that the popup window displays correctly (popup.php test).
      Show
      Apply the patch. Select the Clean theme. Go to Site Administration > Notifications and confirm that the page displays correctly (columns2.php test). Log out and confirm that the login page displays correctly (columns1.php test). Log back in. Create a course and confirm that the course displays correctly (column3.php test). Go to Site Administration -> Reports -> Live Logs and click on 'Live logs from the past hour', confirm that the popup window displays correctly (popup.php test).
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-43348_master

      Description

      Current code in layout files:

      <div class="breadcrumb-nav"><?php echo $OUTPUT->navbar(); ?></div>
      <nav class="breadcrumb-button"><?php echo $OUTPUT->page_heading_button(); ?></nav>

      oops - thats a bit wrong isn't it?
      I think the breadcrumb is navigation, the button is not navigation.

      More information:
      The current mark-up breaks the HTML5 standard as stated in:
      http://www.w3.org/TR/2010/WD-html5-20100624/sections.html#the-nav-element

      Please see attached image 2013-12-12 10_31_14-MooGJB_ Administration_ Appearance_ Themes_ Theme selector.png.

        Attachments

          Activity

            People

            • Assignee:
              gb2048 Gareth J Barnard
              Reporter:
              stuartlamour Stuart Lamour
              Peer reviewer:
              Mary Evans
              Integrator:
              Sam Hemelryk
              Tester:
              Jason Fowler
              Participants:
              Component watchers:
              Adrian Greeve, Mihail Geshoski, Peter Dias, Amy Groshek, David Scotson, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Bas Brands, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            • Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Jan/14