[MDL-43348] html <nav> element on the wrong content in bootstrapbase - Moodle Tracker

XML

Word

Printable

Testing Instructions:
Hide

Apply the patch.

Select the Clean theme.

Go to Site Administration > Notifications and confirm that the page displays correctly (columns2.php test).

Log out and confirm that the login page displays correctly (columns1.php test).

Log back in.

Create a course and confirm that the course displays correctly (column3.php test).

Go to Site Administration -> Reports -> Live Logs and click on 'Live logs from the past hour', confirm that the popup window displays correctly (popup.php test).
Show
Apply the patch. Select the Clean theme. Go to Site Administration > Notifications and confirm that the page displays correctly (columns2.php test). Log out and confirm that the login page displays correctly (columns1.php test). Log back in. Create a course and confirm that the course displays correctly (column3.php test). Go to Site Administration -> Reports -> Live Logs and click on 'Live logs from the past hour', confirm that the popup window displays correctly (popup.php test).
Affected Branches:
MOODLE_25_STABLE, MOODLE_26_STABLE
Fixed Branches:
MOODLE_25_STABLE, MOODLE_26_STABLE
Pull from Repository:
git://github.com/gjb2048/moodle.git
Pull Master Branch:
wip-~~MDL-43348~~_master
Pull Master Diff URL:
https://github.com/gjb2048/moodle/compare/master...wip-MDL-43348_master

Current code in layout files:

<div class="breadcrumb-nav"><?php echo $OUTPUT->navbar(); ?></div>
<nav class="breadcrumb-button"><?php echo $OUTPUT->page_heading_button(); ?></nav>

oops - thats a bit wrong isn't it?
I think the breadcrumb is navigation, the button is not navigation.

More information:
The current mark-up breaks the HTML5 standard as stated in:
http://www.w3.org/TR/2010/WD-html5-20100624/sections.html#the-nav-element

Please see attached image 2013-12-12 10_31_14-MooGJB_ Administration_ Appearance_ Themes_ Theme selector.png.

Participants:: Damyon Wiese, Gareth J Barnard, Jason Fowler, Mark Pearson, Mary Evans, Sam Hemelryk, Stuart Lamour

Component watchers:: Andrew Nicols, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amy Groshek, David Scotson, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Bas Brands