Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43373

Inactive enrolments not dimmed when start and end dates defined

    Details

    • Database:
      Any
    • Testing Instructions:
      Hide

      Prerequisites:

      • A course with manual enrolments enabled and 8 users enrolled.
      • One user with an enrolment with status 'Active' and no start and end dates enabled.
      • One user with an enrolment with status 'Active', start date only enabled and in the past.
      • One user with an enrolment with status 'Active', end date only enabled and in the future.
      • One user with an enrolment with status 'Active', start and end dates enabled with the start date in the past and the end date in the future.
      • One user with an enrolment with status 'Active', start date only enabled and in the future.
      • One user with an enrolment with status 'Active', end date only enabled and in the past.
      • One user with an enrolment with status 'Active', start and end dates enabled with both dates in the past.
      • One user with an enrolment with status 'Active', start and end dates enabled with both dates in the future.

      Test:

      1. Go to the course's 'Enrolled users' page.
      2. Check that the enrolment methods for the first 4 users as described above are displayed as active.
      3. Check that the enrolment methods for the remaining 4 users are displayed as inactive (i.e. dimmed).

      Show
      Prerequisites: A course with manual enrolments enabled and 8 users enrolled. One user with an enrolment with status 'Active' and no start and end dates enabled. One user with an enrolment with status 'Active', start date only enabled and in the past. One user with an enrolment with status 'Active', end date only enabled and in the future. One user with an enrolment with status 'Active', start and end dates enabled with the start date in the past and the end date in the future. One user with an enrolment with status 'Active', start date only enabled and in the future. One user with an enrolment with status 'Active', end date only enabled and in the past. One user with an enrolment with status 'Active', start and end dates enabled with both dates in the past. One user with an enrolment with status 'Active', start and end dates enabled with both dates in the future. Test: 1. Go to the course's 'Enrolled users' page. 2. Check that the enrolment methods for the first 4 users as described above are displayed as active. 3. Check that the enrolment methods for the remaining 4 users are displayed as inactive (i.e. dimmed).
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull Master Branch:
      MDL-43373-master

      Description

      On the enrolled users page, inactive enrolments (e.g. expired enrolments, those that have not yet begun, or those with a disabled enrolment method) are normally displayed with the 'dimmed_text' class. This works fine in most cases, however if there is both a start date and an end date defined for the enrolment, and the current time is outside of those start and end times, the enrolment is displayed like a normal active enrolment.

      This seems to be due to a logic error requiring the current date to be BOTH before the start date AND after the expiry date in order for the enrolment to be considered inactive. Obviously this could never be the case.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Jan/14