Loading...

XML

Word

Printable

Affected Branches:
MOODLE_26_STABLE
Fixed Branches:
MOODLE_27_STABLE
Pull from Repository:
git://github.com/danpoltawski/moodle.git
Pull Main Branch:
~~MDL-43395~~-master
Pull Main Diff URL:
https://github.com/danpoltawski/moodle/compare/12efa52...MDL-43395-master
Testing Instructions:
1. Run unit tests on all 5 database drivers
2. Run behat tests on all 5 database drivers
3. Verify: there are no failures relating to this change (debug messages about LIMIT clauses)

The parameters for get_records are:

get_records($table, array $conditions=null, $sort='', $fields='*', $limitfrom=0, $limitnum=0)

The parameters for get_records_sql are:

get_records_sql($sql, array $params=null, $limitfrom=0, $limitnum=0);

Note that if you are a silly developer like Dan, you might accidentally pass a sort to $limitfrom.

In that case, Moodle silently converts the string to an int without warning the developer. I propose to add a debugdeveloper warning for this.

blocks

MDL-43678 get_records*_sql silently converts invalid limit param to integer (backport of MDL-43395)

caused a regression

MDL-47378 mod_assign: Grading table incorrect type of perpage preference

Discovered while testing

MDL-43720 Behat tests related with listing step defintions in Windows

MDL-43717 Behat test failure on 32bit PHP

has a non-specific relationship to

MDL-43677 Make stricter LIMIT param checking for -1, ''

Testing discovered

MDL-41062 Can not sort gradebook items.

(1 Testing discovered)

Participants:: CiBoT, Dan Poltawski, David Monllaó, Eloy Lafuente (stronk7), Marina Glancy, Michael de Raadt, Petr Skoda, Sam Hemelryk, Tim Hunt