Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43398

Wiki: "Choose..." options cause SQL errors or seen inappropriate.

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.4.7, 2.5.3, 2.6, 2.7
    • 2.5.6, 2.6.3
    • Wiki (2.x)
    • MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • MOODLE_25_STABLE, MOODLE_26_STABLE
    • wip-MDL-43398-master
    • Hide

      a) in a wiki - collaborative: check that the selectbox in Map is defaulted to "page list" and you don't see "Choose..."
      b) in a wiki - collaborative: check that the selectbox in Administration is defaulted to "Remove pages" and you don't see "Choose..."
      c) wiki - view (individual - no group): the user/group select box has no "Choose..." option
      d) wiki - view (individual - separated group): the user/group select box has no "Choose..." option
      e) wiki - view (individual - visible group): the user/group select box has no "Choose..." option

      Show
      a) in a wiki - collaborative: check that the selectbox in Map is defaulted to "page list" and you don't see "Choose..." b) in a wiki - collaborative: check that the selectbox in Administration is defaulted to "Remove pages" and you don't see "Choose..." c) wiki - view (individual - no group): the user/group select box has no "Choose..." option d) wiki - view (individual - separated group): the user/group select box has no "Choose..." option e) wiki - view (individual - visible group): the user/group select box has no "Choose..." option

    Description

      wiki - map menu: "Choose..." displays the "page list", the default. No need the option.
      wiki - administration: "Choose..." displays "Remove pages", the default. No need the option.
      wiki - view (individual - no group): "Choose..." makes no sense, it should be default to the current user.
      wiki - view (individual - seperated group): design needs investigation - Selecting "Choose..." causes a SQL error. From the code there will always be a selected option, so removing the "Choose..." seems a good fix.
      wiki - view (individual - visible group): design needs investigation - Selecting "Choose..." causes a SQL error. From the code there will always be a selected option, so removing the "Choose..." seems a good fix.
      wiki - page_index(): the only call of this function is commented. Apparently it's an undone TODO - I wrote an issue for the wiki: MDL-43358. // @TODO: Fix call to wiki_get_subwiki_by_group

      Attachments

        Issue Links

          Activity

            People

              marina Marina Glancy
              jerome Jérôme Mouneyrac
              Adrian Greeve Adrian Greeve
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Mark Nelson Mark Nelson
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                12/May/14