Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43398

Wiki: "Choose..." options cause SQL errors or seen inappropriate.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.7, 2.5.3, 2.6, 2.7
    • Fix Version/s: 2.5.6, 2.6.3
    • Component/s: Wiki (2.x)
    • Labels:
    • Testing Instructions:
      Hide

      a) in a wiki - collaborative: check that the selectbox in Map is defaulted to "page list" and you don't see "Choose..."
      b) in a wiki - collaborative: check that the selectbox in Administration is defaulted to "Remove pages" and you don't see "Choose..."
      c) wiki - view (individual - no group): the user/group select box has no "Choose..." option
      d) wiki - view (individual - separated group): the user/group select box has no "Choose..." option
      e) wiki - view (individual - visible group): the user/group select box has no "Choose..." option

      Show
      a) in a wiki - collaborative: check that the selectbox in Map is defaulted to "page list" and you don't see "Choose..." b) in a wiki - collaborative: check that the selectbox in Administration is defaulted to "Remove pages" and you don't see "Choose..." c) wiki - view (individual - no group): the user/group select box has no "Choose..." option d) wiki - view (individual - separated group): the user/group select box has no "Choose..." option e) wiki - view (individual - visible group): the user/group select box has no "Choose..." option
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull Master Branch:
      wip-MDL-43398-master

      Description

      wiki - map menu: "Choose..." displays the "page list", the default. No need the option.
      wiki - administration: "Choose..." displays "Remove pages", the default. No need the option.
      wiki - view (individual - no group): "Choose..." makes no sense, it should be default to the current user.
      wiki - view (individual - seperated group): design needs investigation - Selecting "Choose..." causes a SQL error. From the code there will always be a selected option, so removing the "Choose..." seems a good fix.
      wiki - view (individual - visible group): design needs investigation - Selecting "Choose..." causes a SQL error. From the code there will always be a selected option, so removing the "Choose..." seems a good fix.
      wiki - page_index(): the only call of this function is commented. Apparently it's an undone TODO - I wrote an issue for the wiki: MDL-43358. // @TODO: Fix call to wiki_get_subwiki_by_group

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    12/May/14