Moodle
  1. Moodle
  2. MDL-43399

Badge: the "Choose..." option can still be selected once a role is choosen.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5.3, 2.6
    • Fix Version/s: 2.5.4, 2.6.1
    • Component/s: Badges
    • Labels:

      Description

      badge/award.php: The "Choose..." can still be selected once a role is choosen

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Yuliya Bozhko added a comment -

            Sorry for switching assignee. Accidentally discovered a hotkey

            Show
            Yuliya Bozhko added a comment - Sorry for switching assignee. Accidentally discovered a hotkey
            Hide
            Dan Poltawski added a comment -

            Thanks Jerome, looks good to me.

            (BTW that $nothing param is really badly documented!)

            Show
            Dan Poltawski added a comment - Thanks Jerome, looks good to me. (BTW that $nothing param is really badly documented!)
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Note this issue is going to receive a comment from the, still experimental, pre-checker of issues awaiting integration, so accept the results knowing that there are aspects (false positives, the comment contents...) to be improved before this gets final status.

            For any comment, suggestion... MDLSITE-2662 is the issue where these initial runs are being discussed.

            Ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Note this issue is going to receive a comment from the, still experimental, pre-checker of issues awaiting integration, so accept the results knowing that there are aspects (false positives, the comment contents...) to be improved before this gets final status. For any comment, suggestion... MDLSITE-2662 is the issue where these initial runs are being discussed. Ciao
            Hide
            CiBoT added a comment -

            Results for MDL-43399

            Show
            CiBoT added a comment - Results for MDL-43399 Branch MDL-43399 -25 to be integrated into upstream MOODLE_25_STABLE Executed job http://ci.stronk7.com/job/Precheck%20remote%20branch/739 Execution status: 0 Details: http://ci.stronk7.com/job/Precheck%20remote%20branch/739/artifact/work/smurf.html Branch MDL-43399 -26 to be integrated into upstream MOODLE_26_STABLE Executed job http://ci.stronk7.com/job/Precheck%20remote%20branch/740 Execution status: 0 Details: http://ci.stronk7.com/job/Precheck%20remote%20branch/740/artifact/work/smurf.html Branch MDL-43399 -master to be integrated into upstream master Executed job http://ci.stronk7.com/job/Precheck%20remote%20branch/741 Execution status: 0 Details: http://ci.stronk7.com/job/Precheck%20remote%20branch/741/artifact/work/smurf.html
            Hide
            Damyon Wiese added a comment -

            Thanks Jerome,

            Looks good to me. Integrated to 25, 26 and master.

            Show
            Damyon Wiese added a comment - Thanks Jerome, Looks good to me. Integrated to 25, 26 and master.
            Hide
            Adrian Greeve added a comment -

            Tested on the 2.5, 2.6, and master branches.
            Works as described.
            Test passed.

            Show
            Adrian Greeve added a comment - Tested on the 2.5, 2.6, and master branches. Works as described. Test passed.
            Hide
            Damyon Wiese added a comment -

            David built a framework for behat
            At first just to test this and that
            10000+ steps written
            Sounds like we're all smitten
            And David should be smiling at that

            Thanks for reporting, patching, and testing this issue. It has been released upstream along with 64 others today.

            Show
            Damyon Wiese added a comment - David built a framework for behat At first just to test this and that 10000+ steps written Sounds like we're all smitten And David should be smiling at that Thanks for reporting, patching, and testing this issue. It has been released upstream along with 64 others today.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: