Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.6
-
Component/s: Assignment (2.2)
-
Testing Instructions:
-
Affected Branches:MOODLE_26_STABLE
-
Fixed Branches:MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-43438-master -
Pull Master Diff URL:
Description
- Enable Assignment 2.2
- Create a new activity Upload a single file
- File in the form and click 'Submit and display'
Expected
- The activity is created and you're redirected to the activity
Actual
- The following fatal error occurs:
Fatal error: Cannot redeclare class assignment_uploadsingle in /Users/fmc/code/php/repositories/i26/moodle/mod/assignment/type/uploadsingle/assignment.class.php on line 443
This worked fine on 2.4 and 2.5
Gliffy Diagrams
Attachments
Issue Links
- Testing discovered
-
-
- Closed
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
Looks safe and makes sense to me.
Thanks Fred.
Skipping the PR comment because everything looks good.
Hi guys,
this is just a message to share with you that I'm going to perform a test of the automated pre-checker against all the current issues awaiting integration (16 issues).
So, soon, you'll get some extra comments in this issue with some information from the pre-checker. Note it's not final, but just an experiment and there are lots of things to improve, from the message itself to various false positives in the checkers. So take any report with caution, it's not 100% accurate yet.
Please, feel free to comment any idea/objection @ MDLSITE-2662. I'll be collecting everything there.
TIA and ciao 
Results for MDL-43438
- Branch
MDL-43438-24 to be integrated into upstream MOODLE_24_STABLE- Executed job http://ci.stronk7.com/job/Precheck%20remote%20branch/697
- Execution status: 0
- Details: http://ci.stronk7.com/job/Precheck%20remote%20branch/697/artifact/work/smurf.html
- Branch
MDL-43438-25 to be integrated into upstream MOODLE_25_STABLE- Executed job http://ci.stronk7.com/job/Precheck%20remote%20branch/698
- Execution status: 0
- Details: http://ci.stronk7.com/job/Precheck%20remote%20branch/698/artifact/work/smurf.html
- Branch
MDL-43438-26 to be integrated into upstream MOODLE_26_STABLE- Executed job http://ci.stronk7.com/job/Precheck%20remote%20branch/699
- Execution status: 0
- Details: http://ci.stronk7.com/job/Precheck%20remote%20branch/699/artifact/work/smurf.html
- Branch
MDL-43438-master to be integrated into upstream master- Executed job http://ci.stronk7.com/job/Precheck%20remote%20branch/700
- Execution status: 0
- Details: http://ci.stronk7.com/job/Precheck%20remote%20branch/700/artifact/work/smurf.html
Pinching this off Eloy (sorry + thanks Eloy).
This has been integrated now
Tested and passed during integration review, thanks Fred.
Thank you, your code has landed just in time for 2013.
Merry Christmas and may your 2014 be even better than 2013.
Kind regards with much holiday spirit
Sam
Here we have 2.6.2 and when click to see sent assignments, we get this error:
Fatal error: Cannot redeclare class assignment_uploadsingle in
<root-of-moodle>/mod/assignment/type/uploadsingle/assignment.class.php on line 443
Requesting peer review. I was not able to replicate this on 2.4 and 2.5, but I don't think it hurts to backport the patch, it should certainly have been a require_once in the first place. Also, this affects every assignment plugin, not just uploadsingle as I first thought.