Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Blocker
Fix Version/s: 2.5.5, 2.6.2, 2.7
Affects Version/s: 2.4.7, 2.5.3, 2.6
Component/s: Unit tests
Labels:
- ci
- patch
- triaged

Affected Branches:
MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
Fixed Branches:
MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
Pull from Repository:
git://github.com/mr-russ/moodle.git
Pull Main Branch:
~~MDL-43440~~-master
Pull Main Diff URL:
https://github.com/mr-russ/moodle/compare/master...MDL-43440-master
Testing Instructions:
Hide

Install the OUBlog plugin from https://github.com/moodleou/moodle-mod_oublog.

Run the /admin/tool/phpunit/cli/init.php script to reinitialise your PHPUnit tables.

Run all phpunit tests and ensure there are no issues.
Show
Install the OUBlog plugin from https://github.com/moodleou/moodle-mod_oublog . Run the /admin/tool/phpunit/cli/init.php script to reinitialise your PHPUnit tables. Run all phpunit tests and ensure there are no issues.

In the unit test test_grade_edit_tree_column_range_get_item_cell, the id of an assignment is being used to find a context module instance. This should be using the cmid.

For a vanilla checkout of Moodle, this happens to pass because the cmid and the id are both 1, but if your build includes other plugins which create course modules as part of their installation (e.g. oublog which uses a post_install hook to create a sitewide instance), then the unit test fails.

blocks

MDL-43835 Use unique sequence values on database reset to pick unit testing mistakes

Closed

has a non-specific relationship to

MDL-43182 Typo in accesslib causes performance optimization to be skipped (backport of MDL-43049)

Closed

has been marked as being related by

MDL-43926 Unit tests fail if an add-on creates a course category at install time

Closed

will be (partly) resolved by

MDL-43835 Use unique sequence values on database reset to pick unit testing mistakes

Closed

Assignee:: Russell Smith

Reporter:: Michael Aherne

Peer reviewer:: Tim Hunt

Integrator:: Marina Glancy

Tester:: Ankit Agarwal

Participants:: Ankit Agarwal, CiBoT, Marina Glancy, Mark Nelson, Michael Aherne, Michael de Raadt, Russell Smith, Sam Hemelryk, Sam Marshall, Tim Hunt

Votes:: 0 Vote for this issue

Watchers:: 8 Start watching this issue

Created:: 18/Dec/13 5:43 PM

Updated:: 07/Feb/14 2:29 PM

Resolved:: 07/Feb/14 2:29 PM

Details

Description

Attachments

Issue Links

Activity

People

Dates

Clockify