Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43466

Assignment submission help text may give a wrong message to students

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6, 3.3.3, 3.4
    • Fix Version/s: 3.5
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      Test 1
      1. Log in as an admin.
      2. Create a course.
      3. Create an assignment activity.
      4. Enrol a student.
      5. Log in as the student and visit the assignment activity.
      6. Confirm it says ‘You have not made a submission yet’ under the ‘Add submission’ button.
      7. Add a submission.
      8. Confirm it says ‘You can still make changes to your submission’ under the ‘Edit submission’ button.
      Show
      Test 1 Log in as an admin. Create a course. Create an assignment activity. Enrol a student. Log in as the student and visit the assignment activity. Confirm it says ‘You have not made a submission yet’ under the ‘Add submission’ button. Add a submission. Confirm it says ‘You can still make changes to your submission’ under the ‘Edit submission’ button.
    • Affected Branches:
      MOODLE_26_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-43466_master

      Description

      Currently in v2.6+ if a student who can still make changes to his/her submission visits the submission status page, the message reads "Make changes to your submission". This could be confusing to those students who have made their final submission. Why is Moodle still telling them to make changes to their submission?

      A simple improvement could be to change the Edit submission message to "You can still make changes to your submission".
      Also perhaps a new/better message for Add submission would be "You have not made a submission yet."

      The following changes to code are required:

      • Add and update these lang strings in mod/assign/lang/en/assign.php
        $string['addsubmission_help'] = 'You have not made a submission yet.';
        $string['editsubmission_help'] = 'You can still make changes to your submission.';
      • Replace the first occurrence of 'editsubmission_help' in render_assign_submission_status() in /mod/assign/renderer.php to 'addsubmission_help'

        Attachments

        1. addsubmission.jpg
          addsubmission.jpg
          66 kB
        2. assignment1.jpg
          assignment1.jpg
          73 kB
        3. editsubmission.jpg
          editsubmission.jpg
          75 kB
        4. Step6-Confirmed.PNG
          Step6-Confirmed.PNG
          63 kB
        5. Step8-Confirmed.PNG
          Step8-Confirmed.PNG
          63 kB

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            rjnl Rajneel Totaram
            Peer reviewer:
            Mark Nelson
            Integrator:
            Eloy Lafuente (stronk7)
            Tester:
            Gladys Basiana
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              17/May/18