Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43480

behat tags verification/reorganization to be considered...

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Repeat the following steps using:

      Steps:

      1. Run behat using vendor/bin/behat --config /path/to/behatdataroot/behat/behat.yml --tags '@block_activity_modules,@core_files'
      2. All SHOULD pass
      3. Add a @itest tag to admin/tool/behat/tests/behat/data_generators.feature first line
      4. Run behat using vendor/bin/behat --config /path/to/behatdataroot/behat/behat.yml --tags @itest
      5. All SHOULD pass
      Show
      Repeat the following steps using: firefox (the default selenium browser) chrome ( https://code.google.com/p/selenium/wiki/ChromeDriver ) phantomjs ( http://phantomjs.org/download.html and /wherever/you/store/it/bin/phantomjs --webdriver=4444) Steps: Run behat using vendor/bin/behat --config /path/to/behatdataroot/behat/behat.yml --tags '@block_activity_modules,@core_files' All SHOULD pass Add a @itest tag to admin/tool/behat/tests/behat/data_generators.feature first line Run behat using vendor/bin/behat --config /path/to/behatdataroot/behat/behat.yml --tags @itest All SHOULD pass
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-43480_master

      Description

      Uhm... think we need to review the special @ tags that we have in some tests...

      I was surprised that, when running behat... if I used firefox... there were like 70 steps executed before any communication with selenium, so goutte was being used. Instead, when executing safari or phantomjs... selenium started to get requests immediately.

      Tracing the execution a bit... the very first tag tested is "@block_activity_modules" and it has a (WRONG?) @_only_local tag on it. That's the reason it was skipped by safari, phantom (because we always have to exclude that tag with those browsers).

      But, curiously... I've executed here the "@block_activity_modules" tag for firefox/chrome/safari/phantomjs and it's passing for all them (in fact goutte does it all the time). So really that test does not need to be excluded at all.

      More yet, I've executed "@block_activity_modules" using the real browsers for ALL the tests (forcing default_session to selenium2) and it has passed the 70 steps without any problem for all the browsers.

      So it's clear that such feature does not need the @_only_local at all.

      Perhaps we should do a review of all current uses, maybe too the @_switch_window ones, perhaps verifying if @_only_local is the best name or it should be @_upload or something else. Also, maybe, we would need a new @_force_real_browser for those tests requiring a real browser, not working under goutte (Similar to the @javascript one...)

      In any case, 1st step is to verify that @_only_local is not applied to features nor requiring it. And that's what this issue is about.

        Attachments

          Activity

            People

            Assignee:
            dmonllao David Monllaó
            Reporter:
            stronk7 Eloy Lafuente (stronk7)
            Peer reviewer:
            Frédéric Massart Frédéric Massart
            Integrator:
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Tester:
            Mark Nelson Mark Nelson
            Participants:
            Component watchers:
            Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              10/Mar/14