Moodle
  1. Moodle
  2. MDL-43482

Lot of "Only variables should be passed by reference" messages when running the chatd daemon

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.7, 2.5.3, 2.6
    • Fix Version/s: 2.4.8, 2.5.4, 2.6.1
    • Component/s: Chat
    • Labels:
    • Testing Instructions:
      Hide

      (difficulty: easy, requires system administrator access to the server hosting the Moodle instance)

      1. Check the PHP settings of your Moodle instance to be sure that STRICT errors are reported as well;
      2. Start the chat in daemon mode, without &, and expect not to be flooded by Only variables should be passed by reference on line NNN:

        # php mod/chat/chatd.php --start
        Moodle chat daemon v1.0 on PHP 5.4.23
         
        [2013-12-22 11:24:28] *IMPORTANT* Started Moodle chatd on port 9111, listening socket Resource id #72
        

        Note: NNN = 699 on master branch, before applying the PR.

      3. Test the chat activity, using the daemon, as described in http://docs.moodle.org/26/en/Chat_settings#Site_administration_settings.
      Show
      (difficulty: easy, requires system administrator access to the server hosting the Moodle instance) Check the PHP settings of your Moodle instance to be sure that STRICT errors are reported as well; Start the chat in daemon mode , without & , and expect not to be flooded by Only variables should be passed by reference on line NNN : # php mod/chat/chatd.php --start Moodle chat daemon v1.0 on PHP 5.4.23   [2013-12-22 11:24:28] *IMPORTANT* Started Moodle chatd on port 9111, listening socket Resource id #72 Note: NNN = 699 on master branch, before applying the PR. Test the chat activity, using the daemon, as described in http://docs.moodle.org/26/en/Chat_settings#Site_administration_settings .
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull 2.6 Branch:
      m26_MDL-43482_Lot_Of_Passed_By_Reference_Messages
    • Pull Master Branch:
      m27_MDL-43482_Lot_Of_Passed_By_Reference_Messages

      Gliffy Diagrams

        Issue Links

          Activity

          Hide
          Matteo Scaramuccia added a comment -

          To iTeam: I'm unable to find the right peer reviewer though I've looked at the past history of the chat component code.

          Show
          Matteo Scaramuccia added a comment - To iTeam : I'm unable to find the right peer reviewer though I've looked at the past history of the chat component code.
          Hide
          Matteo Scaramuccia added a comment -

          Rebased.

          Show
          Matteo Scaramuccia added a comment - Rebased.
          Hide
          Matteo Scaramuccia added a comment -

          Hi David,
          could you peer review my PRs?

          TIA,
          Matteo

          Show
          Matteo Scaramuccia added a comment - Hi David, could you peer review my PRs? TIA, Matteo
          Hide
          Petr Skoda added a comment -

          +1

          Show
          Petr Skoda added a comment - +1
          Hide
          Dan Poltawski added a comment -

          Thanks Matteo - integrated to master, 26, 25 & 24

          Show
          Dan Poltawski added a comment - Thanks Matteo - integrated to master, 26, 25 & 24
          Hide
          Michael de Raadt added a comment -

          Test result: Success!

          I ran into two problems. There were some critical warnings reported by the daemon, but these seem to be covered by MDL-43483. Chrome also had problems in the daemon client display, which I've reported in MDL-43602. But the problem raised in this issue has been resolved.

          Show
          Michael de Raadt added a comment - Test result: Success! I ran into two problems. There were some critical warnings reported by the daemon, but these seem to be covered by MDL-43483 . Chrome also had problems in the daemon client display, which I've reported in MDL-43602 . But the problem raised in this issue has been resolved.
          Hide
          Damyon Wiese added a comment -

          David built a framework for behat
          At first just to test this and that
          10000+ steps written
          Sounds like we're all smitten
          And David should be smiling at that

          Thanks for reporting, patching, and testing this issue. It has been released upstream along with 64 others today.

          Show
          Damyon Wiese added a comment - David built a framework for behat At first just to test this and that 10000+ steps written Sounds like we're all smitten And David should be smiling at that Thanks for reporting, patching, and testing this issue. It has been released upstream along with 64 others today.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: