Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43508

Invalid get_string() identifier when using admin/tool/qeupgradehelper/extracttestcase.php

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.7, 2.5.3, 2.6, 2.7
    • Fix Version/s: 2.4.8, 2.5.4, 2.6.1
    • Component/s: Quiz
    • Labels:
    • Testing Instructions:
      Hide

      (difficulty: easy, requires administrator access to the Moodle instance)

      1. Log in as an Administrator;
      2. Point to Site administration > Question engine upgrade helper > Extract test case, i.e. admin/tool/qeupgradehelper/extracttestcase.php;
      3. You should see no warnings about invalid get_string() identifiers and the Question type dropdown is populated with the name of those question type installed in the system and not with the string identifiers e.g. [[calculated]].
      Show
      (difficulty: easy, requires administrator access to the Moodle instance) Log in as an Administrator ; Point to Site administration > Question engine upgrade helper > Extract test case , i.e. admin/tool/qeupgradehelper/extracttestcase.php ; You should see no warnings about invalid get_string() identifiers and the Question type dropdown is populated with the name of those question type installed in the system and not with the string identifiers e.g. [ [calculated] ] .
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      m27_MDL-43508_Invalid_String_Identifier

      Description

      See below the long list, due to the usage of the explicit plugin name instead of pluginname:

      Invalid get_string() identifier: 'calculated' or component 'qtype_calculated'. Perhaps you are missing $string['calculated'] = ''; in /var/www/moodle-master-git-remote/question/type/calculated/lang/en/qtype_calculated.php?
      line 293 of /lib/classes/string_manager_standard.php: call to debugging()
      line 6833 of /lib/moodlelib.php: call to core_string_manager_standard->get_string()
      line 49 of /admin/tool/qeupgradehelper/extracttestcase_form.php: call to get_string()
      line 191 of /lib/formslib.php: call to tool_qeupgradehelper_extract_options_form->definition()
      line 49 of /admin/tool/qeupgradehelper/extracttestcase.php: call to moodleform->moodleform()
       
      Invalid get_string() identifier: 'calculatedmulti' or component 'qtype_calculatedmulti'. Perhaps you are missing $string['calculatedmulti'] = ''; in /var/www/moodle-master-git-remote/question/type/calculatedmulti/lang/en/qtype_calculatedmulti.php?
      line 293 of /lib/classes/string_manager_standard.php: call to debugging()
      line 6833 of /lib/moodlelib.php: call to core_string_manager_standard->get_string()
      line 49 of /admin/tool/qeupgradehelper/extracttestcase_form.php: call to get_string()
      line 191 of /lib/formslib.php: call to tool_qeupgradehelper_extract_options_form->definition()
      line 49 of /admin/tool/qeupgradehelper/extracttestcase.php: call to moodleform->moodleform()
       
      Invalid get_string() identifier: 'calculatedsimple' or component 'qtype_calculatedsimple'. Perhaps you are missing $string['calculatedsimple'] = ''; in /var/www/moodle-master-git-remote/question/type/calculatedsimple/lang/en/qtype_calculatedsimple.php?
      line 293 of /lib/classes/string_manager_standard.php: call to debugging()
      line 6833 of /lib/moodlelib.php: call to core_string_manager_standard->get_string()
      line 49 of /admin/tool/qeupgradehelper/extracttestcase_form.php: call to get_string()
      line 191 of /lib/formslib.php: call to tool_qeupgradehelper_extract_options_form->definition()
      line 49 of /admin/tool/qeupgradehelper/extracttestcase.php: call to moodleform->moodleform()
       
      Invalid get_string() identifier: 'description' or component 'qtype_description'. Perhaps you are missing $string['description'] = ''; in /var/www/moodle-master-git-remote/question/type/description/lang/en/qtype_description.php?
      line 293 of /lib/classes/string_manager_standard.php: call to debugging()
      line 6833 of /lib/moodlelib.php: call to core_string_manager_standard->get_string()
      line 49 of /admin/tool/qeupgradehelper/extracttestcase_form.php: call to get_string()
      line 191 of /lib/formslib.php: call to tool_qeupgradehelper_extract_options_form->definition()
      line 49 of /admin/tool/qeupgradehelper/extracttestcase.php: call to moodleform->moodleform()
       
      Invalid get_string() identifier: 'essay' or component 'qtype_essay'. Perhaps you are missing $string['essay'] = ''; in /var/www/moodle-master-git-remote/question/type/essay/lang/en/qtype_essay.php?
      line 293 of /lib/classes/string_manager_standard.php: call to debugging()
      line 6833 of /lib/moodlelib.php: call to core_string_manager_standard->get_string()
      line 49 of /admin/tool/qeupgradehelper/extracttestcase_form.php: call to get_string()
      line 191 of /lib/formslib.php: call to tool_qeupgradehelper_extract_options_form->definition()
      line 49 of /admin/tool/qeupgradehelper/extracttestcase.php: call to moodleform->moodleform()
       
      Invalid get_string() identifier: 'match' or component 'qtype_match'. Perhaps you are missing $string['match'] = ''; in /var/www/moodle-master-git-remote/question/type/match/lang/en/qtype_match.php?
      line 293 of /lib/classes/string_manager_standard.php: call to debugging()
      line 6833 of /lib/moodlelib.php: call to core_string_manager_standard->get_string()
      line 49 of /admin/tool/qeupgradehelper/extracttestcase_form.php: call to get_string()
      line 191 of /lib/formslib.php: call to tool_qeupgradehelper_extract_options_form->definition()
      line 49 of /admin/tool/qeupgradehelper/extracttestcase.php: call to moodleform->moodleform()
       
      Invalid get_string() identifier: 'missingtype' or component 'qtype_missingtype'. Perhaps you are missing $string['missingtype'] = ''; in /var/www/moodle-master-git-remote/question/type/missingtype/lang/en/qtype_missingtype.php?
      line 293 of /lib/classes/string_manager_standard.php: call to debugging()
      line 6833 of /lib/moodlelib.php: call to core_string_manager_standard->get_string()
      line 49 of /admin/tool/qeupgradehelper/extracttestcase_form.php: call to get_string()
      line 191 of /lib/formslib.php: call to tool_qeupgradehelper_extract_options_form->definition()
      line 49 of /admin/tool/qeupgradehelper/extracttestcase.php: call to moodleform->moodleform()
       
      Invalid get_string() identifier: 'multianswer' or component 'qtype_multianswer'. Perhaps you are missing $string['multianswer'] = ''; in /var/www/moodle-master-git-remote/question/type/multianswer/lang/en/qtype_multianswer.php?
      line 293 of /lib/classes/string_manager_standard.php: call to debugging()
      line 6833 of /lib/moodlelib.php: call to core_string_manager_standard->get_string()
      line 49 of /admin/tool/qeupgradehelper/extracttestcase_form.php: call to get_string()
      line 191 of /lib/formslib.php: call to tool_qeupgradehelper_extract_options_form->definition()
      line 49 of /admin/tool/qeupgradehelper/extracttestcase.php: call to moodleform->moodleform()
       
      Invalid get_string() identifier: 'multichoice' or component 'qtype_multichoice'. Perhaps you are missing $string['multichoice'] = ''; in /var/www/moodle-master-git-remote/question/type/multichoice/lang/en/qtype_multichoice.php?
      line 293 of /lib/classes/string_manager_standard.php: call to debugging()
      line 6833 of /lib/moodlelib.php: call to core_string_manager_standard->get_string()
      line 49 of /admin/tool/qeupgradehelper/extracttestcase_form.php: call to get_string()
      line 191 of /lib/formslib.php: call to tool_qeupgradehelper_extract_options_form->definition()
      line 49 of /admin/tool/qeupgradehelper/extracttestcase.php: call to moodleform->moodleform()
       
      Invalid get_string() identifier: 'numerical' or component 'qtype_numerical'. Perhaps you are missing $string['numerical'] = ''; in /var/www/moodle-master-git-remote/question/type/numerical/lang/en/qtype_numerical.php?
      line 293 of /lib/classes/string_manager_standard.php: call to debugging()
      line 6833 of /lib/moodlelib.php: call to core_string_manager_standard->get_string()
      line 49 of /admin/tool/qeupgradehelper/extracttestcase_form.php: call to get_string()
      line 191 of /lib/formslib.php: call to tool_qeupgradehelper_extract_options_form->definition()
      line 49 of /admin/tool/qeupgradehelper/extracttestcase.php: call to moodleform->moodleform()
       
      Invalid get_string() identifier: 'random' or component 'qtype_random'. Perhaps you are missing $string['random'] = ''; in /var/www/moodle-master-git-remote/question/type/random/lang/en/qtype_random.php?
      line 293 of /lib/classes/string_manager_standard.php: call to debugging()
      line 6833 of /lib/moodlelib.php: call to core_string_manager_standard->get_string()
      line 49 of /admin/tool/qeupgradehelper/extracttestcase_form.php: call to get_string()
      line 191 of /lib/formslib.php: call to tool_qeupgradehelper_extract_options_form->definition()
      line 49 of /admin/tool/qeupgradehelper/extracttestcase.php: call to moodleform->moodleform()
       
      Invalid get_string() identifier: 'randomsamatch' or component 'qtype_randomsamatch'. Perhaps you are missing $string['randomsamatch'] = ''; in /var/www/moodle-master-git-remote/question/type/randomsamatch/lang/en/qtype_randomsamatch.php?
      line 293 of /lib/classes/string_manager_standard.php: call to debugging()
      line 6833 of /lib/moodlelib.php: call to core_string_manager_standard->get_string()
      line 49 of /admin/tool/qeupgradehelper/extracttestcase_form.php: call to get_string()
      line 191 of /lib/formslib.php: call to tool_qeupgradehelper_extract_options_form->definition()
      line 49 of /admin/tool/qeupgradehelper/extracttestcase.php: call to moodleform->moodleform()
       
      Invalid get_string() identifier: 'shortanswer' or component 'qtype_shortanswer'. Perhaps you are missing $string['shortanswer'] = ''; in /var/www/moodle-master-git-remote/question/type/shortanswer/lang/en/qtype_shortanswer.php?
      line 293 of /lib/classes/string_manager_standard.php: call to debugging()
      line 6833 of /lib/moodlelib.php: call to core_string_manager_standard->get_string()
      line 49 of /admin/tool/qeupgradehelper/extracttestcase_form.php: call to get_string()
      line 191 of /lib/formslib.php: call to tool_qeupgradehelper_extract_options_form->definition()
      line 49 of /admin/tool/qeupgradehelper/extracttestcase.php: call to moodleform->moodleform()
       
      Invalid get_string() identifier: 'truefalse' or component 'qtype_truefalse'. Perhaps you are missing $string['truefalse'] = ''; in /var/www/moodle-master-git-remote/question/type/truefalse/lang/en/qtype_truefalse.php?
      line 293 of /lib/classes/string_manager_standard.php: call to debugging()
      line 6833 of /lib/moodlelib.php: call to core_string_manager_standard->get_string()
      line 49 of /admin/tool/qeupgradehelper/extracttestcase_form.php: call to get_string()
      line 191 of /lib/formslib.php: call to tool_qeupgradehelper_extract_options_form->definition()
      line 49 of /admin/tool/qeupgradehelper/extracttestcase.php: call to moodleform->moodleform()
      

        Gliffy Diagrams

          Activity

          Hide
          matteo Matteo Scaramuccia added a comment -

          Hi Petr,
          could you peer review this issue?

          TIA,
          Matteo

          Show
          matteo Matteo Scaramuccia added a comment - Hi Petr, could you peer review this issue? TIA, Matteo
          Hide
          skodak Petr Skoda added a comment -

          I am sorry, I am working on other issues, please do not assign me as reviewer because it prevents others from reviewing issues, thanks

          Show
          skodak Petr Skoda added a comment - I am sorry, I am working on other issues, please do not assign me as reviewer because it prevents others from reviewing issues, thanks
          Hide
          skodak Petr Skoda added a comment -

          Hi, I think the change is ok, but you need the final ok from Tim I am afraid. Thanks for the patch!

          Show
          skodak Petr Skoda added a comment - Hi, I think the change is ok, but you need the final ok from Tim I am afraid. Thanks for the patch!
          Hide
          matteo Matteo Scaramuccia added a comment -

          Hi Tim,
          could you perform a peer review for these PRs?

          TIA,
          Matteo

          Show
          matteo Matteo Scaramuccia added a comment - Hi Tim, could you perform a peer review for these PRs? TIA, Matteo
          Hide
          timhunt Tim Hunt added a comment -

          Looks good to me. Technically, the component mentioned in the commit comment is wrong (this is not the quiz) but that should not hold up integration.

          Show
          timhunt Tim Hunt added a comment - Looks good to me. Technically, the component mentioned in the commit comment is wrong (this is not the quiz) but that should not hold up integration.
          Hide
          matteo Matteo Scaramuccia added a comment -

          Hi Tim,
          TNX! What do you suggest as the right component, Administration?

          TIA,
          Matteo

          Show
          matteo Matteo Scaramuccia added a comment - Hi Tim, TNX! What do you suggest as the right component, Administration ? TIA, Matteo
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Integrated (24, 25, 26 and master), thanks!

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Integrated (24, 25, 26 and master), thanks!
          Hide
          andyjdavis Andrew Davis added a comment -

          Works as described. Passing.

          Show
          andyjdavis Andrew Davis added a comment - Works as described. Passing.
          Hide
          damyon Damyon Wiese added a comment -

          David built a framework for behat
          At first just to test this and that
          10000+ steps written
          Sounds like we're all smitten
          And David should be smiling at that

          Thanks for reporting, patching, and testing this issue. It has been released upstream along with 64 others today.

          Show
          damyon Damyon Wiese added a comment - David built a framework for behat At first just to test this and that 10000+ steps written Sounds like we're all smitten And David should be smiling at that Thanks for reporting, patching, and testing this issue. It has been released upstream along with 64 others today.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Jan/14