Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43538

Deprecate callback argument to confirm_action

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      • git grep for confirm_action and check that no cases provide a callback
      • git grep for M.util.show_confirm_dialog
        • confirm that none of the cases provide a non-function based callback
      • run behat tests
      Show
      git grep for confirm_action and check that no cases provide a callback git grep for M.util.show_confirm_dialog confirm that none of the cases provide a non-function based callback run behat tests
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull Master Branch:
      MDL-43538-master

      Description

      This is a first step to fixing MDL-42428.

      The callback argument is dirty and wrong, and leads to a JavaScript eval() which we should banish.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dobedobedoh Andrew Lyons
              Reporter:
              dobedobedoh Andrew Lyons
              Peer reviewer:
              Petr Skoda Petr Skoda
              Integrator:
              Sam Hemelryk Sam Hemelryk
              Tester:
              Andrew Davis Andrew Davis
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/May/14