Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43558

Turning "Activity Editing Menu" OFF still displays "edit" text in core themes

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Select Base theme.
      2. DISABLE the option to use "Activity editing menus" in Site Administration > Appearance > AJAX and Javascript. (SAVE SETTINGS)
      3. Go to a course page and "Turn editing on".
      4. Verify that the word 'Edit' is not listed alongside the edit icons next to any editable activity/resource listed on the page.
      5. ENABLE the "Activity editing menus" the option to use "Activity editing menus" in Site Administration > Appearance > AJAX and Javascript. (SAVE SETTINGS)
      6. Go back to the course page and verify that the word 'Edit' is listed and that clicking on it displays a dropdown menu of edit icons.
      7. TEST as above with Javascript disabled in the browser, the OUTCOME of which will be such that the 'Edit' toggle should not be present either when "Activity editing menus" setting is Enabled or Disabled.
      Show
      Select Base theme. DISABLE the option to use "Activity editing menus" in Site Administration > Appearance > AJAX and Javascript. (SAVE SETTINGS) Go to a course page and "Turn editing on". Verify that the word 'Edit' is not listed alongside the edit icons next to any editable activity/resource listed on the page. ENABLE the "Activity editing menus" the option to use "Activity editing menus" in Site Administration > Appearance > AJAX and Javascript. (SAVE SETTINGS) Go back to the course page and verify that the word 'Edit' is listed and that clicking on it displays a dropdown menu of edit icons. TEST as above with Javascript disabled in the browser, the OUTCOME of which will be such that the 'Edit' toggle should not be present either when "Activity editing menus" setting is Enabled or Disabled.
    • Affected Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Pull Master Branch:
      MDL-43558_master

      Description

      When you turn OFF "Activity Editing Menu" [via appearance/ajax and javascript] and it displays the editing icons again on the course home page, it still displays the "Edit" with the arrow--which does nothing.

      That "edit" text should go away and only display the editing icons.

      This happens to many core themes. However, it does not happen to the "Clean" theme. I believe it might have to do with themes using Bootstrap (works). Themes it doesn't work in formal white, afterburner, anomaly..only ones I've tested so far.

        Attachments

        1. 2014-01-03_09-23-17.png
          82 kB
          Melissa Benson
        2. 2014-01-03_09-24-56.png
          21 kB
          Melissa Benson
        3. Screen Shot 2014-01-03 at 9.19.11 AM.png
          11 kB
          Melissa Benson
        4. Screen Shot 2014-01-03 at 9.21.08 AM.png
          10 kB
          Melissa Benson

          Activity

            People

            • Votes:
              14 Vote for this issue
              Watchers:
              21 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/May/15