Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43571

Incorrect view of PMs containing a plain text representing a curl CLI verbose output, including the HTML response

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.6
    • Fix Version/s: BACKEND
    • Component/s: Messages
    • Labels:
    • Affected Branches:
      MOODLE_26_STABLE

      Description

      Having exchanged a private message in moodle.org containing the verbose output of a curl CLI command, including an HTTP Redirection prevents me to read the entire message from the web, correctly sent by email as plain text.
      The message from the web console (https://moodle.org/message/index.php?user=<userid1>&id=<userid2> ) appears as:

      Moved Temporarily

      The document has moved here.

      where here is linked with the URL following the Location: word, truncated to be an 83 chars string.
      The curl output exchanged via PM is similar to the ones available in https://moodle.org/mod/forum/discuss.php?d=245261#p1081829.

      Two issues here, the first being the most important since it prevent the user to read the same text received by email:

      1. line starting with <, >, * seems to be dropped: clean_text() is the culprit. Why not, before, encoding all the sensible HTML entities when the message in supposed to be plain text?
      2. Moodle.org have some filters to allow linkification where the MDL-41941 fix should prevent them: maybe applying the filtering chain, format_text(), should be called before applying the HTML cleaning but is already done via message_format_message_text().

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              matteo Matteo Scaramuccia
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated: