-
Type:
Bug
-
Status: Closed
-
Priority:
Trivial
-
Resolution: Fixed
-
Affects Version/s: 2.5.4, 2.6, 2.6.1
-
Component/s: Messages
-
Testing Instructions:
-
Affected Branches:MOODLE_25_STABLE, MOODLE_26_STABLE
-
Fixed Branches:MOODLE_25_STABLE, MOODLE_26_STABLE
-
Pull from Repository:
-
Pull Master Branch:m27_
MDL-43577_Incorrect_Variable_Expansion -
Pull Master Diff URL:
While working on MDL-43571 I've found a trivial issue in the way the named anchor on top of each message has been created, see the HTML source:
...
|
<a name="NNN"></a>
|
<a name="m'.MMM.'"></a>
|
<span class="message-meta"></span>
|
...
|
This is due to an incorrect variable expansion in the code, kind of expecting an echo:
return <<<TEMPLATE
|
<div class='message $class'>
|
<a name="m'.{$message->id}.'"></a>
|
<span class="message-meta"><span class="time">$time</span></span>: <span class="text">$messagetext</span>
|
</div>
|
TEMPLATE;
|