[MDL-43577] Incorrect variable expansion in the message template - Moodle Tracker

XML

Word

Printable

Testing Instructions:
Hide

(difficulty: easy, requires two users to exchange at least a private message)

Send a PM from <user1> to <user2>;

Check <user2> PMs and open the browser dev tools (<F12>): look at the message element to read, in the HTML source, the fixed named anchor, <a name="m<message_id>"></a>.
Show
(difficulty: easy, requires two users to exchange at least a private message) Send a PM from <user1> to <user2> ; Check <user2> PMs and open the browser dev tools ( <F12> ): look at the message element to read, in the HTML source, the fixed named anchor, <a name="m<message_id>"></a> .
Affected Branches:
MOODLE_25_STABLE, MOODLE_26_STABLE
Fixed Branches:
MOODLE_25_STABLE, MOODLE_26_STABLE
Pull from Repository:
https://github.com/scara/moodle
Pull Master Branch:
m27_~~MDL-43577~~_Incorrect_Variable_Expansion
Pull Master Diff URL:
https://github.com/scara/moodle/commit/f5482be6f8ab6a192285df213e87279ac29de1c9

While working on MDL-43571 I've found a trivial issue in the way the named anchor on top of each message has been created, see the HTML source:

...

<a name="NNN"></a>

<a name="m'.MMM.'"></a>

<span class="message-meta"></span>

...

This is due to an incorrect variable expansion in the code, kind of expecting an echo:

    return <<<TEMPLATE

<div class='message $class'>

    <a name="m'.{$message->id}.'"></a>

    <span class="message-meta"><span class="time">$time</span></span>: <span class="text">$messagetext</span>

</div>

TEMPLATE;

Participants:: Andrew Lyons, CiBoT, Dan Poltawski, Eloy Lafuente (stronk7), Matteo Scaramuccia

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)