Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43626

Alternative names not used in survey and externallib

          Details

          • Testing Instructions:
            Hide

            Survey testing

            1. Go to a course (or create one).
            2. Make sure that the recent activity block is displayed somewhere.
            3. Create a survey activity.
            4. Take the survey with a few different students.
            5. Check out the recent activity block and ensure that there are no errors or developer debugging messages.
            Show
            Survey testing Go to a course (or create one). Make sure that the recent activity block is displayed somewhere. Create a survey activity. Take the survey with a few different students. Check out the recent activity block and ensure that there are no errors or developer debugging messages.
          • Affected Branches:
            MOODLE_26_STABLE
          • Fixed Branches:
            MOODLE_26_STABLE
          • Epic Link:
          • Pull from Repository:
          • Pull Master Branch:
            wip-MDL-43626-master
          • Pull Master Diff URL:

            Description

            While testing for similar places to MDL-43283 where the group by was not correct and grepping

            grep -lr 'GROUP BY.*lastname' *

            we have found that mod/survey/lib.php and enrol/externallib.php seem to not be using alternative names.

              Gliffy Diagrams

                Attachments

                  Issue Links

                  Discovered while testing

                  Improvement - An enhancement to an existing Moodle feature. MDL-44996 Update externallib webservice functions to return additional name fields.

                  • Minor - Minor loss of function where workaround is possible
                  • Open
                  Testing discovered

                  Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-45211 Undefined variables in survey graph generator

                  • Minor - Minor loss of function where workaround is possible
                  • Open

                  Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-43283 Error reading from database after leaving Chat activity

                  • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
                  • Closed

                    Activity

                    Ascending order - Click to sort in descending order
                    Hide
                    Permalink
                    ankit_frenz Ankit Agarwal added a comment -

                    I wonder why the unit tests for the webservices never found this? Is it because alternate name field is disabled in the phpunit/behat site by default? Anyway this clearly needs to be investigated and resolved so all these missing pieces gets noticed. You can do it in a separate issue if you want.

                    Rest looks good.

                    Cheers

                    Show
                    ankit_frenz Ankit Agarwal added a comment - I wonder why the unit tests for the webservices never found this? Is it because alternate name field is disabled in the phpunit/behat site by default? Anyway this clearly needs to be investigated and resolved so all these missing pieces gets noticed. You can do it in a separate issue if you want. Rest looks good. Cheers
                    Hide
                    Permalink
                    abgreeve Adrian Greeve added a comment -

                    After talking with Ankit, and further investigation, we discovered that the external lib problem is in a deprecated function, so I have removed the code fix for that section.
                    I've created an issue (MDL-44996) for updating the externallib webservices to include additional name fields.

                    Show
                    abgreeve Adrian Greeve added a comment - After talking with Ankit, and further investigation, we discovered that the external lib problem is in a deprecated function, so I have removed the code fix for that section. I've created an issue ( MDL-44996 ) for updating the externallib webservices to include additional name fields.
                    Hide
                    Permalink
                    cibot CiBoT added a comment -

                    Results for MDL-43626

                    • Remote repository: git://github.com/abgreeve/moodle.git
                    Show
                    cibot CiBoT added a comment - Results for MDL-43626 Remote repository: git://github.com/abgreeve/moodle.git Remote branch wip- MDL-43626 -26 to be integrated into upstream MOODLE_26_STABLE Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/2873 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/2873/artifact/work/smurf.html Remote branch wip- MDL-43626 -master to be integrated into upstream master Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/2874 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/2874/artifact/work/smurf.html
                    Hide
                    Permalink
                    poltawski Dan Poltawski added a comment -

                    Integrated to master and 26

                    Show
                    poltawski Dan Poltawski added a comment - Integrated to master and 26
                    Hide
                    Permalink
                    dobedobedoh Andrew Nicols added a comment -

                    Thanks Adrian,

                    Working as described - passing.

                    In testing this, I picked up on another bug in Survey - MDL-45211.

                    Show
                    dobedobedoh Andrew Nicols added a comment - Thanks Adrian, Working as described - passing. In testing this, I picked up on another bug in Survey - MDL-45211 .
                    Hide
                    Permalink
                    stronk7 Eloy Lafuente (stronk7) added a comment -

                    Your code is now part of Moodle upstream, many thanks!

                    It's a constant, continuous,
                    spectacular world we live in,
                    and every day you see things that
                    just knock you out, if you pay attention.

                    Robert Irwin

                    Show
                    stronk7 Eloy Lafuente (stronk7) added a comment - Your code is now part of Moodle upstream, many thanks! It's a constant, continuous, spectacular world we live in, and every day you see things that just knock you out, if you pay attention. Robert Irwin

                      People

                      • Votes:
                        0 Vote for this issue
                        Watchers:
                        2 Start watching this issue

                        Dates

                        • Created:
                          Updated:
                          Resolved:
                          Fix Release Date:
                          12/May/14