I wonder why the unit tests for the webservices never found this? Is it because alternate name field is disabled in the phpunit/behat site by default? Anyway this clearly needs to be investigated and resolved so all these missing pieces gets noticed. You can do it in a separate issue if you want.

Rest looks good.

Cheers

After talking with Ankit, and further investigation, we discovered that the external lib problem is in a deprecated function, so I have removed the code fix for that section.
I've created an issue (MDL-44996) for updating the externallib webservices to include additional name fields.

Results for MDL-43626

• Remote repository: git://github.com/abgreeve/moodle.git

• Remote branch wip-MDL-43626-26 to be integrated into upstream MOODLE_26_STABLE
  • Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/2873
  • Details: http://integration.moodle.org/job/Precheck%20remote%20branch/2873/artifact/work/smurf.html

• Remote branch wip-MDL-43626-master to be integrated into upstream master
  • Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/2874
  • Details: http://integration.moodle.org/job/Precheck%20remote%20branch/2874/artifact/work/smurf.html

Integrated to master and 26

Thanks Adrian,

Working as described - passing.

In testing this, I picked up on another bug in Survey - MDL-45211.

Your code is now part of Moodle upstream, many thanks!

It's a constant, continuous,
spectacular world we live in,
and every day you see things that
just knock you out, if you pay attention.

Robert Irwin