[MDL-43626] Alternative names not used in survey and externallib - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_26_STABLE
Fixed Branches:
MOODLE_26_STABLE
Epic Link:
Additional name field debugging issues.
Pull from Repository:
git://github.com/abgreeve/moodle.git
Pull Master Branch:
wip-~~MDL-43626~~-master
Pull Master Diff URL:
https://github.com/abgreeve/moodle/compare/af8a432...wip-MDL-43626-master
Testing Instructions:
Hide

Survey testing

Go to a course (or create one).

Make sure that the recent activity block is displayed somewhere.

Create a survey activity.

Take the survey with a few different students.

Check out the recent activity block and ensure that there are no errors or developer debugging messages.
Show
Survey testing Go to a course (or create one). Make sure that the recent activity block is displayed somewhere. Create a survey activity. Take the survey with a few different students. Check out the recent activity block and ensure that there are no errors or developer debugging messages.

While testing for similar places to ~~MDL-43283~~ where the group by was not correct and grepping

grep -lr 'GROUP BY.*lastname' *

we have found that mod/survey/lib.php and enrol/externallib.php seem to not be using alternative names.

Discovered while testing

MDL-44996 Update externallib webservice functions to return additional name fields.

Testing discovered

MDL-43283 Error reading from database after leaving Chat activity

MDL-45211 Undefined variables in survey graph generator

Participants:: Adrian Greeve, Andrew Lyons, Ankit Agarwal, CiBoT, Dan Poltawski, Eloy Lafuente (stronk7), Marina Glancy

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Laurent David, Sabina Abellan, Sara Arjona (@sarjona), Juan Leyva, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo