Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43646

Change "disapprove[d]" occurrences in behat tests to "unapprove[d]"

    Details

    • Affected Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE

      Description

      This is a followup / regression of MDL-43590, where a bunch of "disapprove[d]" ocurrences in Moodle 26 and master were changed to the better "unapprove[d]" term.

      This has lead to at least 1 behat scenario failing:

      01. Link matching locator "'Disapprove'" not found.
          In step `And I follow "Disapprove"'.                                         # behat_general::click_link()
          From scenario `Approve and disapprove glossary entries'.                     # mod/glossary/tests/behat/entries_require_approval.feature:7
          Of feature `A teacher can choose whether glossary entries require approval'. # mod/glossary/tests/behat/entries_require_approval.feature
      

      This is about to fix those tests. Ciao

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Holding this a bit till it's decided if "unapprove" (as a verb) is finally used.

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Holding this a bit till it's decided if "unapprove" (as a verb) is finally used.
              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Ok, this is the decision: https://tracker.moodle.org/browse/MDL-43590?focusedCommentId=264103&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-264103 So changing behat tests to fulfill it.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Closing this as fixed. This is the commit (applied to both 26_STABLE and master):

              http://git.moodle.org/gw?p=integration.git;a=commitdiff;h=12efa52762064bf07af4559702fbb2d2f40f7194

              And the execution of the failing feature above ended ok with the patch applied:

              --name "Approve and disapprove"
              Moodle 2.7dev (Build: 20140110), mariadb, 7123ae8f9a841e2746f02bb003dbb08149f16eef
              Server OS "Darwin", Browser: "phantomjs"
              Started at 10-01-2014, 19:50
              ...................................................................... 70
              ...
               
              1 escenario (1 exitosos)
              73 pasos (73 exitosos)
              0m26.572s
              

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Closing this as fixed. This is the commit (applied to both 26_STABLE and master): http://git.moodle.org/gw?p=integration.git;a=commitdiff;h=12efa52762064bf07af4559702fbb2d2f40f7194 And the execution of the failing feature above ended ok with the patch applied: --name "Approve and disapprove" Moodle 2.7dev (Build: 20140110), mariadb, 7123ae8f9a841e2746f02bb003dbb08149f16eef Server OS "Darwin", Browser: "phantomjs" Started at 10-01-2014, 19:50 ...................................................................... 70 ...   1 escenario (1 exitosos) 73 pasos (73 exitosos) 0m26.572s

                People

                • Assignee:
                  stronk7 Eloy Lafuente (stronk7)
                  Reporter:
                  stronk7 Eloy Lafuente (stronk7)
                  Integrator:
                  Eloy Lafuente (stronk7)
                  Tester:
                  Eloy Lafuente (stronk7)
                  Participants:
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    13/Jan/14